"Unable to send mail" with send tokenized e-mail

Drupal's mail function changed significantly in Drupal 6. See attached patch. Haven't tested it myself yet at all, so I marked it as code needs work.

Subscribe - (sorry for duplication - I posted a similar problem here http://drupal.org/node/242944#comment-836294)

Slightly improved title.

@superjacent and @redfox75 - can you test seanr's patch in #1?

It's not working for me. Get this error:
Parse error: syntax error, unexpected T_VARIABLE in /home/.../public_html/.../drupal-6.2/sites/all/modules/token/token_actions.module on line 140.

Line 140 is in this piece of code:

function token_actions_mail($key, &$message, $params) {
$message['subject'] = $params['subject']
$message['body'] = $params['body'];
}

@superjacent - that's a parser error because it expected a semicolon.

re-rolled patch fixes that and applies cleanly.

greggles, I applied your patch and noticed that e-mail message bodies were still empty

+  $params['message'] = drupal_html_to_text(token_replace_multiple($context['message'], $context));

should be

+  $params['body'] = drupal_html_to_text(token_replace_multiple($context['message'], $context));

But I'm also noticing that I still get the 'unable to send email' error when my action is assigned to saving a comment rather than creating a node. Sending e-mail works on the node action, but not the comment action. I'm not seeing anything in the code in token - maybe something in actions.inc?

@calebtr - thanks for finding that. I've re-rolled it to include that change.

Did you try this for users or taxonomies?

Since this seems to fix at least some of the cases I feel like it's probably worth committing and have moved it back to CNR to reflect that. Additional reviews would be awesome.

Thanks for the patch and reviews, seanr and calebtr! I've now committed this to 6.x - http://drupal.org/cvs?commit=127492

There also is one more thing... in token_actions.module, line 151 needs to be modified. I ran into a problem with Mollom trying to alter a new comment mail sent out by token module. It was expecting $message['body'] to be an array. I took a look at some other examples in core (e.g. contact_mail in contact.module) and confirmed that this is the correct behavior.

Currently:

function token_actions_mail($key, &$message, $params) {
  $message['subject'] = $params['subject'];
  $message['body'] = $params['body'];
}

Should Be:

  $message['body'][] = $params['body'];

Great. This makes it work for me on a test site.

And I've now committed that fix - http://drupal.org/cvs?commit=131207

Thanks, Dave Reid!