in module parser_common_syndication, function parser_simplepie_feedapi_feed, operation 'compatible', when the feed is cached, the type of the feed is not persisted to the cache. Therefore on line 37, on subsequent calls (re: nodeapi/update) the type is not subsequently retrieved (it's null).

This patch persists the type to the cache so it is later retrieved correctly.

CommentFileSizeAuthor
feedapi-5.patch1.62 KBstashlbai

Comments

mustafau’s picture

mustafau commented
Status: Needs review » Needs work

I do not understand why line 37 returns "$downloaded_string->type". Type is always "XML feed".

Instead of attaching type to the cached feed you should return "XML feed" in line 37.

mustafau’s picture

mustafau commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Component: Code » Code feedapi (core module)
Status: Needs work » Closed (fixed)

The feed type is not an important property of the feed object anymore.