Make advforum work with Zen

Michelle - May 1, 2008 - 01:55
Project:Advanced Forum
Version:5.x-1.x-dev
Component:Theming
Category:task
Priority:normal
Assigned:Michelle
Status:closed
Description

See http://drupal.org/node/246109

Michelle

#1

JohnAlbin - May 1, 2008 - 02:49
Category:task» feature request

subscribing. :-)

#2

Michelle - May 1, 2008 - 02:55
Category:feature request» task

Just fixing the category so it doesn't get forgotten.

Michelle

#3

KeithHurst - May 1, 2008 - 14:40

Subscribing also, as I'm having no end of problems with Zen and ADVForum. Will examine the multiple threads on this later.

Thanks Michelle, it's a fantastic job you're doing.

Keith

#4

Michelle - May 8, 2008 - 03:11
Status:active» active (needs more info)

path_to_subtheme has been added but is untested. I'd appreciate it if someone who uses Zen could give it a try.

I'm drawing a blank on what I'm supposed to do with the new Zen preprocess functions... Could you refresh my memory, please?

Thanks,

Michelle

#5

annez - May 8, 2008 - 14:08

It's not working for me, though I may have something set up wrong. It looks like advanced_forum_theme_path in advanced_forum.module doesn't see path_to_subtheme even though I can call it from my template.php. Am investigating but maybe someone with more knowledge of Drupal and/or PHP will have an idea about what's going wrong. Do functions defined in templates get added later maybe?

#6

Michelle - May 8, 2008 - 15:07
Status:active (needs more info)» active

Darn, I was hoping it would just work... I guess I'll need to install Zen and figure it out. Thanks for the feedback.

Michelle

#7

JohnAlbin - May 9, 2008 - 05:01
Status:active» patch (code needs review)

Okay, this patch does 3 things…

  1. Changes theme_image(...) to theme('image', ...). (Not actually related to this bug, but still a theme-layer bug.)
  2. Changes _phptemplate_callback() to use a proper $suggestions array. For example,
    _phptemplate_callback("$forum_theme/advf-forum-topic-list", $variables) becomes
    _phptemplate_callback("advf_forum_topic_list", $variables, array("$forum_theme/advf-forum-topic-list"))
  3. Adds theme_init() before checking for the existance of path_to_subtheme, since advforum seems to be checking for its existence before drupal theme layer is started (i.e. before Zen's template.php is read.)

And that should fix the final issues with Zen and advforum. :-)

AttachmentSize
zen.patch8.54 KB

#8

Michelle - May 11, 2008 - 02:40
Status:patch (code needs review)» fixed

Comitted. Thanks!

Michelle

#9

excell - May 18, 2008 - 16:34

excuse me - could you tell me please what file I put the patch into?

Thanks.

#10

Anonymous (not verified) - June 1, 2008 - 16:42
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.