Download & Extend
Advanced Forum » Issues

Make advforum work with Zen

Posted by Michelle on May 1, 2008 at 1:55am
Project:Advanced Forum
Version:5.x-1.x-dev
Component:Theming
Category:task
Priority:normal
Assigned:Michelle
Status:closed (fixed)

Issue Summary

See http://drupal.org/node/246109

Michelle

Login or register to post comments

Comments

#1

Posted by JohnAlbin on May 1, 2008 at 2:49am
Category:task» feature request

subscribing. :-)

#2

Posted by Michelle on May 1, 2008 at 2:55am
Category:feature request» task

Just fixing the category so it doesn't get forgotten.

Michelle

#3

Posted by Keith Hurst on May 1, 2008 at 2:40pm

Subscribing also, as I'm having no end of problems with Zen and ADVForum. Will examine the multiple threads on this later.

Thanks Michelle, it's a fantastic job you're doing.

Keith

#4

Posted by Michelle on May 8, 2008 at 3:11am
Status:active» postponed (maintainer needs more info)

path_to_subtheme has been added but is untested. I'd appreciate it if someone who uses Zen could give it a try.

I'm drawing a blank on what I'm supposed to do with the new Zen preprocess functions... Could you refresh my memory, please?

Thanks,

Michelle

#5

Posted by annez on May 8, 2008 at 2:08pm

It's not working for me, though I may have something set up wrong. It looks like advanced_forum_theme_path in advanced_forum.module doesn't see path_to_subtheme even though I can call it from my template.php. Am investigating but maybe someone with more knowledge of Drupal and/or PHP will have an idea about what's going wrong. Do functions defined in templates get added later maybe?

#6

Posted by Michelle on May 8, 2008 at 3:07pm
Status:postponed (maintainer needs more info)» active

Darn, I was hoping it would just work... I guess I'll need to install Zen and figure it out. Thanks for the feedback.

Michelle

#7

Posted by JohnAlbin on May 9, 2008 at 5:01am
Status:active» needs review

Okay, this patch does 3 things…

  1. Changes theme_image(...) to theme('image', ...). (Not actually related to this bug, but still a theme-layer bug.)
  2. Changes _phptemplate_callback() to use a proper $suggestions array. For example,
    _phptemplate_callback("$forum_theme/advf-forum-topic-list", $variables) becomes
    _phptemplate_callback("advf_forum_topic_list", $variables, array("$forum_theme/advf-forum-topic-list"))
  3. Adds theme_init() before checking for the existance of path_to_subtheme, since advforum seems to be checking for its existence before drupal theme layer is started (i.e. before Zen's template.php is read.)

And that should fix the final issues with Zen and advforum. :-)

AttachmentSize
zen.patch 8.54 KB

#8

Posted by Michelle on May 11, 2008 at 2:40am
Status:needs review» fixed

Comitted. Thanks!

Michelle

#9

Posted by excell on May 18, 2008 at 4:34pm

excuse me - could you tell me please what file I put the patch into?

Thanks.

#10

Posted by Anonymous (not verified) on June 1, 2008 at 4:42pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here