I'm installing the most recent versions of Notifications, Messaging, Token, etc. Everything seems to be working fine. My nodes are created, they go in the queue, the mail gets sent. But when the mail arrives, the subject is "T". The only header info before the digested messages is "T" and the footer just says T. When I check the database, the appropriate message parts (that previously worked in earlier versions) are shown in messaging_message_parts, though the copies in messaging_store show T for the subject and so forth.

This only seems to apply to the digest or perhaps just to cck nodes. If I create an individual cck node and set it to send as soon as possible, the result has the T problem. If I create a page node and set it to send as soon as possible, it properly creates the subject, header, and footer. I cannot seem to create a digested version of pages as they seem to stay set at send as soon as possible, even though the default is 15 minutes and I've set the only subscription to 15 minutes. So I think that's another bug. But the T problem is the one that has me stopped. Thanks.

Comments

jaydub’s picture

jaydub commented

yes I had the same happen although I disregarded it
until seeing this report

HallSL’s picture

HallSL commented

Does anyone have any idea when it broke? In February, doing R&D for a project, we got a reasonable digest working. Now we're building the actual site and this key piece is blatantly busted. All attempts I've made so far to install older versions of given modules have either thrown other errors or had the same problem. Can someone recommend to me a working set of the critical modules?

jaydub’s picture

jaydub commented

Well I can see where the bug is happening but I am not
clear as to the purpose of the code that was changed
and that brought about this bug. I'll post the info here
and hopefully Jose can sort out the fix.

In notifications_process_digest() the digest message
subject is set here:

  // Create message. Do all this in one replacement, then strip out the subject
  $text['subject'] = notifications_message_part('digest', 'subject', $send_method);
  $text['header'] = notifications_message_part('digest', 'header', $send_method);
  $text['footer'] = notifications_message_part('digest', 'footer', $send_method);

but a couple of lines up the variable $text is already set and is
a string at this point. The functions that return values to $text
above are assuming that $text is an array which seems to be
why the bug shows your subject as 'T' or something similar.

    // Check duplicate notifications for the same event
    if (!isset($list[$digest_type][$digest_value]['line'][$event->eid])) {
      $line = !empty($event->text['digest']) ? $event->text['digest'] : $info['line'];
      $text = $list[$digest_type][$digest_value]['line'][$event->eid] = notifications_text_replace($line, $event->objects);
      notifications_log("Digesting line $text");

appears to be the offending code - the line that sets a value
for $text is a new line of code since April 13 or so.

If you change the $text variable from the // Check duplicate
notifcations.... code block to something else say $text_line
then the following code that sets the subject, header, footer
all work as before.

jose reyero’s picture

jose reyero commented
Assigned: Unassigned » jose reyero
Priority: Normal » Critical
Status: Active » Fixed

There should be a Beta3 fixing this bug available in the next minutes.

It's exactly the line jaydub says, thank you.

The changes in message parts and digesting had been introduced to support the 'Notifications Lite' feature, http://drupal.org/node/253109

(We really need to cover message digesting with the Unit Tests :-( )

HallSL’s picture

HallSL commented

Excellent. Thanks so much! It works beautifully.

One word of warning -- this version seems to have removed the interval of 15 minutes and resets all time intervals, in some cases to never. We're just in testing, so we caught it quickly, but that could be a real problem for someone with a live site and lots of subscribers.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.