I just tried to run potx-cli.php on the pathauto codebase, to make sure I was going to translate against the latest set of strings, but I got a few errors:
freso@nayru /s/h/l/h/d/s/a/m/pathauto> php ../potx/potx-cli.php
Processing pathauto.inc...
Invalid marker content in pathauto.inc:418
* watchdog('Pathauto',t('It appears that you have installed Pathauto, which depends on token, but token is either not installed or not installed properly.'))Processing pathauto_node.inc...
Processing pathauto_taxonomy.inc...
Processing pathauto_user.inc...
Processing pathauto.module...
Invalid menu 'title' definition found in pathauto_menu() in pathauto.module on line 41Invalid menu 'title' definition found in pathauto_menu() in pathauto.module on line 51
Processing pathauto.install...
Processing pathauto.info...
Processing pathauto.js...
Processing contrib/pathauto_node_event.inc...
Processing contrib/pathauto_node_i18n.inc...Done.
So I gave the lines referenced a look and realised that all three errors were due to use of a superfluous call to t(). I ripped those calls out and made a patch. :) (Note that the strings are still being pulled into the .pot, so there shouldn't be any string additions following. Just better code that doesn't save already translated strings in the watchdog logs, etc.)
Oh, and for reference, this is how potx-cli.php behaves when running after having the patch applied:
freso@nayru /s/h/l/h/d/s/a/m/pathauto> php ../potx/potx-cli.php
Processing pathauto.inc...
Processing pathauto_node.inc...
Processing pathauto_taxonomy.inc...
Processing pathauto_user.inc...
Processing pathauto.module...
Processing pathauto.install...
Processing pathauto.info...
Processing pathauto.js...
Processing contrib/pathauto_node_event.inc...
Processing contrib/pathauto_node_i18n.inc...Done.
Mmm. Smooth. ;)
| Comment | File | Size | Author |
|---|---|---|---|
| pathauto_less_t.d6.patch | 1.9 KB | Freso |
Comments
Comment #1
hass commentedMarked #253901 as duplicate.
Comment #2
greggles@hass - since your duplicate contained a very similar patch does that mean you feel this is RTBC?
@Freso and @hass - thanks for catching these.
Comment #3
hass commentedI think so, but haven't tested the above patch of the "apply" works... the code changes are correct.
Comment #4
gregglesCommitted to HEAD. Thanks to both of you for the code/review.
Comment #5
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.