Here is a patch I did on cvs, it includes

  • restrict adsense to certain pages (useful to not show adsense on home page or admin pages, but everywhere else)
  • style div to customize display of adsense through css
  • function to observe Adsense limit of 3 per page
  • added new format 234x60

Please let me know if you use this.

CommentFileSizeAuthor
adsense_0.patch4.9 KBRobRoy

Comments

kbahey’s picture

kbahey commented
Assigned: Unassigned » kbahey

Thanks for the changes. They all make sense.

I only modified the limit to be configurable, since Google may change that in the future. It still defaults to 3, so does the same thing anyways.

kbahey’s picture

kbahey commented

The page matching in this patch was not working, and therefore no ads were being displayed at all.

I got that fixed now.

Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
RobRoy’s picture

RobRoy commented
Version: » 4.6.x-1.x-dev
Status: Fixed » Active

Whatever you changed in the patch matching has broken it for me, the old code I submitted worked for me.

kbahey’s picture

kbahey commented
Status: Active » Fixed

Thanks for noticing this.

Fixed in HEAD and 4.6.

Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)