Cookies not working...

noahb - May 3, 2008 - 16:18
Project:Tabbed Block
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:joetsuihk
Status:closed
Description

Hi and thanks for your module!

I was trying it out and it seems that part of the code that sets and gets cookies is not working correctly. The tabs always go back to the default state on reload.

I tried on both FF and IE, and the results were the same. Any ideas?

#1

noahb - May 3, 2008 - 17:23

After a bit of testing I found at least 2 things that are keeping the cookies from working.
First is that the wrong cookie value is being set in the tabbed_block_tab function.
Second is the code to trigger the link back to the previous state was removed from the lastest releases. This could be intentional, but it seems to not work at all without it. The line that had been removed was:

    $(this).find(".tabbed_block-nav").children("li").eq(frag.substr(-1)).trigger("click");

#2

joetsuihk - May 5, 2008 - 21:34
Assigned to:Anonymous» joetsuihk

confirmed bug.
thanks a lot

working on patch.

#3

noahb - May 6, 2008 - 16:04

Sorry I can't roll a patch right now, but I attached a copy of the js file that is now working.

AttachmentSize
tabbed_block.js_.txt 3.46 KB

#4

joetsuihk - May 7, 2008 - 20:28
Status:active» fixed

committed to head

#5

Anonymous (not verified) - May 21, 2008 - 20:32
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.