To make life easier, 6.x should offer both methods, and break most code out into 1 or 2 .inc files.

CommentFileSizeAuthor
#5 README-254328-5.patch3.54 KBpwolanin
#4 both-methods-254328-3.patch11.46 KBpwolanin
#2 both-methods-254328-2.patch11.4 KBpwolanin
#1 both-methods-254328-1.patch10.81 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Title: include both methods, refactos files » include both methods, refactor files
Assigned: Unassigned » pwolanin
Status: Active » Needs review
StatusFileSize
new both-methods-254328-1.patch10.81 KB

untested patch

pwolanin’s picture

pwolanin commented
StatusFileSize
new both-methods-254328-2.patch11.4 KB

modestly tested patch

quicksketch’s picture

quicksketch
he/him
commented

Tested out with Webform (both methods). If it can work with Webform, it should work with anything :D

Works great in both cases. Having an option is definitely a big improvement. My only suggestion is to clarify the two radio button options. It's not clear to me what "the form" is, or what I'm saving before editing.

Pre-populate the form
Save then edit

I'd suggest:

Pre-populate a new node form
Save the new node then edit

But this is minor. The code itself works great and does good cleanup.

pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed
StatusFileSize
new both-methods-254328-3.patch11.46 KB

thanks for the review - committed the attached to HEAD - making a release.

pwolanin’s picture

pwolanin commented
StatusFileSize
new README-254328-5.patch3.54 KB

and clean up the README too.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

  • Commit cd00da0 on 6.x-1.x, 7.x-1.x, master, 8.x-1.x by pwolanin: 
    #254328 get both methods in one module, add uninstall code
  • Commit 64f92a9 on 6.x-1.x, 7.x-1.x, master, 8.x-1.x by pwolanin:
    #254328 update README