Change of project in comment does not update assigned options

1. the validation code for the assigned dropdown seems wrong. first, project_issue_assigned_choices() always returns an array, so the !isset($assigned_choices) will always pass. second, if we're trying to make sure that the submitted user is a valid assignee for the new project, won't the FAPI choice-checker take care of that?
2. if the js code needs to know the issue nid (which is a static value from the perspective of the AJAX we're using here), then it seems more proper to pass it as a js setting instead of a hidden form value.
3. // Build the HTML output for the rid select. -- this code comment looks wrong for building the assigned select
4. function project_issue_update_project($pid, $cid = NULL, $rid = NULL, $assigned_uid = NULL, $issue_nid = NULL) -- the order of the args there seems goofy to me. i think it would be less confusing if we reorganized those instead of just tacking the new args on the end. perhaps pid, nid, cid, rid, uid? just some order that makes intuitive sense...
5. the assigned select you're building via AJAX has it's #required value set to TRUE, but i'm not seeing where that's consistent with the way the form item is normally built -- is there a reason for that?

attached patch:

• rips out the validation code for the assigned user that was added in the previous patch. after talking w/ aclight, neither of us can determine why it's necessary
• moves the issue nid to a js setting
• reorders the args of project_issue_update_project() to something i think is more sensible.
• fixes bad comment in #3, unneeded #required attribute mentioned in #5 above, and cleans up some more inconsistencies with the code that adds the assigned select box. all the errors look like copy/paste issues.
• adds doxygen to project_issue_update_project()
• fixes the node_load() for loading the issue in project_issue_update_project() to make sure it checks that the passed nid belongs to a project issue. also changed the node_load() for the project loading for consistency.
• fixes the code that disables the selects during the AJAX call -- the extra arg in .attr() broke it.

tested, and this all seems to be working beautifully now. gonna leave it CNR for a bit in case anybody else wants to jab at it...

Why are we doing this:

Is the idea that the static cache doesn't help us in this AJAX menu handler, since we're only looking up a single project per "page load" anyway?

Otherwise, patch looks good visually. I haven't tested it yet.

no, the idea is that we have no real validation on the pid, we're just trusting the url that the AJAX request sends.

and also what you said about single page loads. :)

This patch fixes the doxygen of project_issue_update_project() to start with a one line summary and also fixes the @param assigned_uid part. In addition, removes a blank line from the start of the function.

with updated comment

unified diff this time

Reviewed and tested. Please commit to DRUPAL-5--2 and HEAD. Thanks!

committed to 5.x-2.x, HEAD, deployed on d.o

Automatically closed -- issue fixed for two weeks with no activity.