Hi Goz great module, I have fixed quite a few bugs in 5.x-1.1-beta1 as follows

1. Node form wasn't saving to table
2. XML file wasn't taking data from node but from settings
3. XML file had extra lines - use '\n' NOT '\r\n'
4. Object width and height was not taking data from node
5. XML file was being written with 1 and 0 istead of yes and no

I tried creating a patch but got a french version and 5.x-1.1-beta1 is in English so I am not sure what to patch against. I have attached the patch (which changes all the french terms to english) and the edited module as a txt file. Hopefully this is helpful. If you. If you want mr to patch against a different file let me know.

Regards
Geoff

CommentFileSizeAuthor
#2 gpd_fixes2.patch12.58 KBbehindthepage
diaporama.txt22.24 KBbehindthepage
gpd_edit.patch19.52 KBbehindthepage

Comments

behindthepage’s picture

behindthepage commented

Another bug

aligntitles needs to be in hook_load

function diaporama_load($node) {
  $diaporama = db_fetch_object(db_query('SELECT nid, width, height, transition, speed, timer, showbuttons, alignbuttons, aligntitles, randomstart FROM {diaporama} WHERE vid = %d', $node->vid));
  return $diaporama;
}
behindthepage’s picture

behindthepage commented
Status: Active » Needs review
StatusFileSize
new gpd_fixes2.patch12.58 KB

Here are all the above fixes patched against DRUPAL-5 version of Diaporama.

enzo de simone’s picture

enzo de simone commented

Thanks

goz’s picture

goz commented

Thanks for the patch Geoff.
I had already fixed some bug after hopfrog reports bug, but some modifications you do like replacing $edit by $node are great :)

So i do some changes in my module :
1) Check my SQL. (Aouch xD)
2) See 1)
3) \r are no more
4) Width and height took data from node (but i have to rebuild images for that so it doesn't totally work)
5) I take your code for change 0 and 1 to yes or no (like on dewslider site)

Regards

goz’s picture

goz commented
Status: Needs review » Closed (fixed)

Bug is fixed