Backport of the crud file from D6 Version

gordon - May 4, 2008 - 12:39
Project:Content Construction Kit (CCK)
Version:5.x-1.x-dev
Component:content.module
Category:feature request
Priority:normal
Assigned:gordon
Status:needs review
Description

To help with testing http://drupal.org/project/issues/48429 I have back ported the crud file from the drupal 6 version.

AttachmentSize
cck-crudbackport.patch33.81 KB

#1

gordon - May 6, 2008 - 00:54

We have added these patches to Lonely Planets system, and we found a bug with deleteing fields.

Here is a new patch

AttachmentSize
cck-crudbackport.patch 34.33 KB

#2

gordon - May 11, 2008 - 13:49

I have made an update to this patch, so that all the field updates use the crud file like they do in D6. I also found and fixed the problem with the creation of the tables a second time.

AttachmentSize
cck-crudbackport.patch 50.55 KB

#3

KarenS - May 11, 2008 - 20:54

Could you please explain what bugs you found and fixed?

#4

gordon - May 11, 2008 - 23:13

The bug that I found was actually in the crud file in that when a new instance of a field was found it would try and create the table a second time.

#5

gordon - May 12, 2008 - 14:30

Ok, I found some more problems with the system trying to alter tables twice. I think this is complete now. However there is a couple of failed tests which I am going cross eyed looking at.

AttachmentSize
cck-crudbackport.patch 50.41 KB

#6

gordon - May 18, 2008 - 02:03

I have found the last bug in the crud file and it is now passing *all* the tests that have been backported from Drupal 6.

AttachmentSize
cck-crudbackport.patch 67.82 KB

#7

gordon - May 18, 2008 - 02:09

Oops, I added additional changes that were already committed.

AttachmentSize
cck-crudbackport.patch 42.47 KB

#8

gordon - June 30, 2008 - 03:27

I found a bug with one of the tables which caused some fields not to save data.

AttachmentSize
cck-crudbackport.patch 42.79 KB

#9

yched - June 30, 2008 - 11:47

Gordon, many thanks for your work on this. We're not forgetting it, but we're currently focusing on a D6 RC for now.
Just a quick note to make sure you saw that D6 CRUD API commit : http://drupal.org/cvs?commit=123933

#10

gordon - June 30, 2008 - 13:11

No Problem, Just for me at LP, we just can't use D6 yet maybe after the new year we will be able to upgrade, but until then we need CCK to be at it's best.

And these patches I believe that it will make CCK last until D5's end of life.

#11

evanchsa - August 4, 2008 - 19:31

Does the 2008-07-25 5.x freeze mean this feature will not make it in?

#12

gordon - September 6, 2008 - 06:10

Here is an update for the new version of CCK

AttachmentSize
cck-crudbackport.patch 39.84 KB
 
 

Drupal is a registered trademark of Dries Buytaert.