This patch for drigg_embed corrects the thumbnail code for most online video providers. The only providers I haven't been able to fix are:

Veoh
GoogleVideo
CollegeHumor (won't fix)

I suggest support for CollegeHumor is removed from drigg_embed. They have partnered with adware/spyware authors (Zango/180 Solutions, for example), and directs traffic to their sites.

Regards,
.

CommentFileSizeAuthor
#10 drigg_embed.module-final.patch9.61 KBd0t101101
drigg_embed.module.thumbnail.patch7.67 KBd0t101101

Comments

mercmobily’s picture

mercmobily commented

Hi,

Apologies for being slack with this patch.
Can you confirm that it applies fine to Drigg 1.33?
Sorry about this... I hate getting you guys to do things twice :-(

Merc.

d0t101101’s picture

d0t101101 commented

No worries :)

I will verify that the patch applies to the latest drigg, and that its working as expected, once again. Problem is, to test this thoroughly again I have to configure another site and create a bunch of new scoops using the various online video providers...

.

mercmobily’s picture

mercmobily commented

Hi,

Again, please accept my most sincere apologies.

Merc.

d0t101101’s picture

d0t101101 commented

Apology accepted :)

The patch did apply to drigg_embed 1.33 cleanly. Will get back to you on this ASAP after adequate testing.

Regards,
.

mercmobily’s picture

mercmobily commented

Hi,

OK. I am happy for you to take out support for dodgy video services if you think that's a good idea.
Also... well, I don't suppose you could also have a look at this:

http://drupal.org/node/259230

...? Only if it's not too much trouble...

I am trying to get all of the bugs fixed before I move onto feature requests, but I am finding it a little challenging :-D

Bye!

Merc.

d0t101101’s picture

d0t101101 commented

Great, i'll update the patch to remove collegehumor then.

I'll also try to put together a regex (in drigg_embed) that removes everything after the & for youtube videos. For reference, I also suggested this a while back:
http://drupal.org/node/257715

Regards,
.

d0t101101’s picture

d0t101101 commented

Problem with the youtube regex solved. Here is the new version:
/youtube\.com\/watch\?v=(\w[\w|-]*)/

Funny thing is I didn't even have to leave drupal.org to find a solution:
http://drupal.org/node/88192

:]

This will be included in a forthcoming patch.

.

d0t101101’s picture

d0t101101 commented
Version: 5.x-1.31 » 5.x-1.33

The above regex introduced a new problem, which I diagnosed and resolved. Here is the final patch, with a few additional changes, namely:

-typo in veoh div ("veohr") corrected.
-removed support for collegehumor
-changed revver thumb size to match the rest (80x60).
-fixed youtube URL regex - caused thumbnails not to work properly if URL contained a '&' or other special characters.

Hope to see my first drigg contribution applied to HEAD, sometime soon :D

Best regards,
.

mercmobily’s picture

mercmobily commented

Hi,

I was going to apply the patch right now. However... you forgot to attach it!!! :-D

Merc.

d0t101101’s picture

d0t101101 commented
StatusFileSize
new drigg_embed.module-final.patch9.61 KB

HA!

Here you go.
.

mercmobily’s picture

mercmobily commented
Status: Needs review » Fixed

Hi,

Applied!
(At 6:00AM in Boston, after sleeping 7 jet-lagger hours, and before organising Lunch with Richard Stallman :-D )

The patch is in DRUPA-5. Marking this as fixed - please let me know if there are any problems. It will be rolled out in the next release (which I won't do just yet, since I got [rightly] told off for making too many releases...)

Merc.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.