Just by reading through the code, I might have seen a potential bug. The variables array has %name, whereas the default value for the variable uses email_confirm_confirmation_email_subject %username.

  $variables = array(
    '%name' => $user->name,
    '%site' => variable_get('site_name', 'drupal'),
    '%email_url' => $url,
  );

  $from = variable_get('email_confirm_confirmation_email_author', variable_get('site_mail', ini_get('sendmail_from')));
  $bcc = variable_get('email_confirm_confirmation_email_bcc', '');

  $subject = strtr(variable_get('email_confirm_confirmation_email_subject', 'Email address change request for %username at %site'), $variables);

It's a minor bug, but not critical because when the variable is not empty, it will use %name.

Comments

jaydub’s picture

Status: Active » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.