Continents API

giorgio79 - May 6, 2008 - 09:44
Project:Country codes API
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Wim Leers
Status:closed
Description

How about adding continents to it? :)

There has already been some work done
http://drupal.org/node/161792

#1

mrfelton - March 21, 2009 - 12:03
Component:User interface» Code

I do think this would be a nice addition to the countries_api. However, if it is to be included, I think that

a) more information should be provided about the continents (at least a name to go with the two letter code)
b) it should be provided as a countries_api sub module, as this is not core to the api that the module aims to provide, and many people would not want the additional functionality and overhead.

#2

Wim Leers - June 20, 2009 - 00:44
Title:Continents» Continents API
Version:5.x-1.x-dev» 6.x-1.x-dev
Assigned to:Anonymous» Wim Leers
Status:active» reviewed & tested by the community

I needed this, so I just wrote it. Based my code on countries_api and regions_api of course.

Since CVS is unable to create patches for new directories AFAIK, I'm just attaching a patch rolled through SVN. Should work just as well. Will be using this in production at http://driverpacks.net in a couple of hours.
Also attaching a .zip just in case.

AttachmentSize
continents_api.patch 6.33 KB
continents_api.zip 3.18 KB

#3

Wim Leers - June 20, 2009 - 00:50
Status:reviewed & tested by the community» needs review

Oops, accidentally picked the wrong status. Sorry about that.

#4

Wim Leers - July 17, 2009 - 17:17

It's been in use for almost a month now and no issues so far — it is an extremely simple module after all.

Any chance this gets committed some time soon?

#5

mrfelton - July 17, 2009 - 17:34

I'll make this happen over the weekend. Thanks for your contribution.

#6

mrfelton - July 18, 2009 - 09:30
Status:needs review» fixed

commited to cvs and backported to the 5.x branch. Thanks

#7

System Message - August 1, 2009 - 09:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.