hook_feedapi_edit_option() is not used and seems unnecessary.

Additionaly does FeedAPI really need hook_feedapi_settings_form('general').

Comments

mustafau’s picture

mustafau commented
Category: support » task
aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Active » Fixed

Thanks, that obsolete hook call was removed.
Yes, FeedAPI needs this for per-feed and per-content-type , not parser and not processor dependent settings.

mustafau’s picture

mustafau commented
Status: Fixed » Postponed (maintainer needs more info)

I want to keep this issue active since I believe that hook_feedapi_settings_form() is also unnecessary.

Add-on modules can inject their settings fields into "Feed API" group using regular hook_form_alter() hook. I might come up with an experimental patch to make this clear.

mustafau’s picture

mustafau commented
Status: Postponed (maintainer needs more info) » Postponed
neclimdul’s picture

neclimdul
He/Him
commented
Component: Code » Code (general)

A note, it is currently impossible for modules to add usable settings to the feedapi setting form because of the way the fieldset at $form['feedapi'] is created and the way _feedapi_populate overides the normal form behavior.

1) with out some module weight magic, it is likely that many modules will have their api array overidden by:

    $form['feedapi'] = array(
      '#type' => 'fieldset',
       ...
    );

2) _feedapi_populate (and the _feedapi_update/_feedapi_insert) do some very unintuative things surrounding storing and populating #default_value. The default_value one caused me no small amount of pain figuring out.

So not unnecessary yet but probably something that should be removed dependent on the above 2 issues.

indytechcook’s picture

indytechcook commented

I have used the hook_feedapi_settings_form hook in a few modules I have created including FeedAPI Taxonomy Compare. I found it nice to have the setting interjected into the proper spot with out having to mess with the weighting.