First of all let me say I'm completely new to this issue reporting so I hope I'm doing it the right way. I've installed a Drupal 6 installation locally to (slowly) complete a site and in the meanwhile learn more about Drupal. I have upgraded to 6.1 and later 6.2 and have several modules installed in the sites/all/modules/ directory.

I have updated the Glossary module today but I don't know if it was the good approach for updating modules. I simply copied all the new files into the glossary directory, disabled the module and than enabled it again. I got an error saying I have to run update.php, which I did. Now Glossary works properly on the nw version, but there seems to be some problems.

First of all I have it set the term indicator to display a superscript i (filtered html), but in the page it shows (not in superscript): i] (which works as a link correctly).

I decided to try the standard icon, but it didn't display the icon because it's not pointing to the correct location. Let's say I installed in http://localhost/drupal/. The module seems to be looking for the gif image in http://localhost/sites/all/modules/glossary/

I already tried clearing cache for both the module and Drupal and tried in both Maxthon browser (IE7) and firefox.

I hope I have done this correctly. Thanks for this great module, if nobody has done this yet I'm considering writing a Dutch translation for this module.

CommentFileSizeAuthor
#6 glossary-1.3-superscript-concat-fixed.patch665 bytessylvaingirard

Comments

Stephane91’s picture

Stephane91 commented
Status: Postponed (maintainer needs more info) » Active

Hello,
I have the same problem but worth because I can't find a way to switch the indicator to display anything else but *], the option in glossary module desapeared?
The ] is very disturbing. And the database has been upgraded, so there's not an elegant way to go to previous option...
I find out why I cannot change indicator to abbr or acronym. I uncheck module and recheck it. It rebuild the options of the module in basic first install mode and a message appeared on the top That I have no vocabulary selected in input format. I have access to all full html, filtered html... I missed B4. This was because I checked the Hide unused input format tabs, I was unable to view that they was unused... (I may not be clear)
I still have the annoying ] coming with wathever I put next * or ? or ! ...

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Active » Postponed (maintainer needs more info)

@libeco: that looks like the right place for the standard icon, assuming you copied it to that directory. Your method is pretty much what I always do (usually a directory-level copy though). And I usually don't even bother disabling and re-enabling. There was also a change to the CSS file, did you also copy it to the directory?

The brackets were in the patch that was supplied and I had my doubts about them. I have removed them (-dev).

@Stephane91: I'm not sure what you mean that you can't switch the display. All the options are still there. But the database wasn't really upgraded; the update function just removed the absolute link variable and changed it to a link style variable. Falling back would mean no more than having to save the settings again - and then only if you used absolute links.

Stephane91’s picture

Stephane91 commented
Status: Active » Postponed (maintainer needs more info)

Hello and thanks for this great module.
Beside the bracket it works now pretty fine.
What I understood of my problem after upgrading :
When the module upgrade it seems to uncheck the vocabury in input format. You start with a blank page isn't it ?
As I check the option Hide unused input format tabs in general option I was unable to access to what I use to have (full HTML, filtered...) and to access to link style and superscript choice (* in my case).
That's all for me.

While you're fixing this small bug I choosed an other method (Replace with abbr link) witch is fine too. I find it harder to read text and a bit more intrusive, if the term is correct, for the reader; small superscript is very fine because you see it and you can avoid it.
That's all.
Thank again.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

The brackets will be gone when the -dev version rolls out at Noon GMT.

I'll need to see why it unchecked the vocabulary - it shouldn't have done that.

Actually "abbr" is the preferred standard now (over acronym), but IE6 doesn't recognize it, so I left both option in. I prefer hovertip, but the 6.x version of that module is quirky right now.

libeco’s picture

libeco commented

@ NancyDru: Thanks for your reply, however I'm very sure that's not the correct directory to look for. Look at the difference.
http://localhost/drupal/
http://localhost/sites/all/modules/glossary/
The second one seems to ignore the drupal/ directory.

I had a look at the new glossary.css file and it seems to be missing quite some data compared to the previous version, lines 3-11 only display this:

abbr.glossary-indicator,
acronym.glossary-indicator,
sup.glossary-indicator,
span.glossary-indicator,
a.glossary-indicator,
a.glossary-icon,
img.glossary-indicator {
  cursor: help;
}

compared to lines 2-8 in the previous version:

a.glossary-indicator {
  vertical-align: super;
  cursor: help;
  font-size: 60%;
  padding-left: 2px;
  font-weight: bold
}

Thanks again for the help!

sylvaingirard’s picture

sylvaingirard commented
StatusFileSize
new glossary-1.3-superscript-concat-fixed.patch665 bytes

I don't quite get this reply. Do you mean that the superscript displaying will be(is already) removed in the dev version or that it is fixed?

*EDIT:
Nevermind this, got it from the repository. The superscript thingie still had a bug in it, tho. Patch for that is attached.

sylvaingirard’s picture

sylvaingirard commented

libeco: you need to configure the path for the image, as far as i know. Default it is set at /sites/all/modules/glossary/glossary.gif which is correct if drupal is installed in the root of your site. If drupal is installed in a subdirectory, as in your case, you need to edit that path to /<drupalsubdir>/sites/all/modules/glossary/glossary.gif which would be /drupal/sites/all/modules/glossary/glossary.gif for you...

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Assigned: Unassigned » nancydru

@girards - the brackets have been removed from the superscript. I just committed your fix (-dev).

The CSS change is because we now use a <sup> tag rather than CSS to make it look superscripted.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

@libeco: don't make the change above, please. When the new -dev version rolls out, please try it. I added base_path() to the path name.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

@Stephane91 - ahh, I bet you disabled and re-enabled the module to upgrade. Any time the module is enabled, all settings are returned to the default values.

libeco’s picture

libeco commented

@ NancyDru: The dev version fixes only part of the problem. The bracket is now gone. However, I still don't get any superscript in Maxthon (IE7), firefox or Opera.

Secondly the icon's helptext says:
If you chose icon above, enter the URL of the glossary icon relative to the root of your Drupal site.
Which means the standard value of /sites/all/modules/glossary/glossary.gif should be pointing to http://localhost/drupal/sites/all/modules/glossary/glossary.gif in my case, which it doesn't, while it did do this in the previous version (6.x-1.2) as far as I can recall.

Thanks again!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Please try the newest -dev release when it rolls up (midnight GMT). Also, if you disabled and re-enabled the module, please re-save all your settings.

libeco’s picture

libeco commented

@ NancyDru: this one is a step forward once again, the text is now superscript and is working properly for me in Maxthon (IE7), firefox and Opera.

The icon problem hasn't changed though.

Thanks again!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Did you try re-saving the settings?

libeco’s picture

libeco commented

Yes, I saved all the settings again of all the tabs, cleared cache of both glossary and site, but no luck. I must say I didn't disable en re-enable this time...

But when doing so, it stilldoesn't make a difference.

Thanks again!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Okay, let's try getting back to defaults. Go into your variable table (PhpMyAdmin, or similar) and delete "glossary_icon_x" where x is the format number (e.g, "Filtered HTML" is probably 1). Then see what it generates for the default and re-save it.

libeco’s picture

libeco commented

I tried but it didn't change anything. I deleted all three glossary_icon_x, disabled module, enabled module, ran update.php forced it to use 6100 and looked what changed, which was... nothing. The path in the DB remains /sites/all/modules/glossary/glossary.gif

I can the drupal directory in front, but than the help line underneath is not correct since it's pointing to the drupal root. Am I the only one with this problem?

Thanks again!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

You're the only one reporting it, but that doesn't mean the only that has it. I don't have any sites that are not at root level, so it's hard for me to see what's wrong. Can you provide a URL?

libeco’s picture

libeco commented

No sorry, it's just a test locally. Eventually the actual website might end up in the root, but it's also possible it will be a subdomain.

Thanks!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

How about "View source" and copy the portion around the link?

libeco’s picture

libeco commented

Sure, here it is, just a dummy text:
Manu Chao<a href="/2008-04-26_drupaltest/glossary/term/1" title="Manu Chao is singer of the track me gusta tu" class="glossary-icon"><img src="/sites/all/modules/glossary/glossary.gif" /></a><br />

Thanks!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I'm guessing your base path is "2008-04-26_drupaltest"? And it's on the link, but not the img. Hmm.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Please try the -dev version when it rolls up at midnight GMT.

In the meantime, if you are comfortable with it, change line 408 from:

$img = '<img src="'. variable_get("glossary_icon_$format", 'glossary.gif') ."\" />";

to:

$img = '<img src="'. base_path() . variable_get("glossary_icon_$format", 'glossary.gif') ."\" />";
libeco’s picture

libeco commented

That does the trick, although in my module file it was line 417, I didn't get the latest -dev version yet I guess, which I'll do after midnight as advised.

Thanks!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

The -dev will have a small change to the settings form that will display the base path.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Postponed (maintainer needs more info) » Fixed
libeco’s picture

libeco commented

I can confirm that with the last dev version both problems are fixed.

Thanks for your help on this great module, I will try creating a Dutch translation file when I get the hang of the structure used in the .po file.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Fantastic! Thanks for the feedback. And I'll be looking for your translation.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.