Missing $hook in 'phptemplate_preprocess' calls

Deciphered - May 7, 2008 - 02:19
Project:Zen
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Just upgraded to updated to the latest Dev build and I got the following error:

warning: Missing argument 2 for phptemplate_preprocess_node(), called in /[path to subtheme]/template.php on line 95 and defined in /[path to zen]/zen/template.php on line 193.

Problem is basically some of the preprocess hooks didn't get the $hook argument, specifically those that follow the line:

// First run Zen's preprocess function.

I'll try to roll a patch if I get some time.

#1

Deciphered - May 7, 2008 - 02:28
Status:active» patch (code needs review)

Here's the patch, think I got all references.

AttachmentSize
zen-6.x-1.x-dev-fix_hook.patch3.89 KB

#2

JohnAlbin - May 13, 2008 - 05:02
Status:patch (code needs review)» fixed

HI Stuart,

Thanks for the patch. It looks like it works as advertised.

But the fix for #249532: Allow subthemes to have preprocess hooks without tpl files. allowed me to remove all the phptemplate_preprocess* functions. Now the base theme's preprocess functions get called without having that clunky first line in each of the sub-theme's preprocess functions.

#3

Anonymous (not verified) - May 27, 2008 - 05:13
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.