generic/donation items affecting shipping costs

Regarding my comment above, this bug is still effective with the latest 4.6 maintenance release (as of 6/23/2005).

Any ideas about this issue?

Matthias,

Is this bug fixable in the 4.6 release? I'm willing to send some funds¹ your way to bring this issue to the top of your "to-do" list.

¹ This functionality is needed by my non-profit [read: cash-poor] employer (homepage at http://nlca.com).

The scope of this bug seems to be expanding in the 4.6 ecommerce package.

With today's ecommerce.tar.gz, shipping calculations/costs are now being applied to *all* items, regardless of whether they are "non-shippable" or "donation", etc.... This behavior occurs even when non-shippable or donation items are the only ones in the cart.

I have the address module turned on. Can't seem to shake this bug.

What then if I have tangible/shippable items that require shipping charges?

OK. I'm no php whiz, but it doesn't look to me like the following function, located at line 330 of shipping.module 4.6 accounts for any way to determine whether $item is shippable. Can someone smarter check on this?

function shipping_calculate($items) {

  $type = variable_get("shipping_method", "");
  $pivot_element = 0;
  $cost = 0;

  if ($type == "subtotal") {
    foreach ($items as $item) {
      $pivot_element += $item->qty * $item->price;
    }
  }
  else {
    foreach ($items as $item) {
      $pivot_element += $item->qty;
    }
  }

  $function = $type. "_load";
  $ship = $function();
  $numset = count($ship['ship_item_slot']);
  for ($i = 0; $i < $numset; $i++) {
    $item       = $ship['ship_item_slot'][$i];
    $price      = $ship['ship_price_slot'][$i];

    /* Check for range match */
    if (strstr($item, '-')) {
      list($low, $high) = explode('-', $item);
      if ($pivot_element >= $low and $pivot_element <= $high) {
        $cost = $price;
      }
    }
    /* Check for exact item quantity match */
    elseif ($item == $pivot_element) {
      $cost = $price;
    }
  }

  return $cost;
}

I think I've fixed this bug!

Replace the entire IF/ELSE function at line 330 in shipping.module with this code:

if ($type == "subtotal") {
    foreach ($items as $item) {
      if (product_is_shippable($item->nid)) {
        $pivot_element += $item->qty * $item->price;
      }
    }
  }
  else {
    foreach ($items as $item) {
      if (product_is_shippable($item->nid)) {
        $pivot_element += $item->qty;
      }
    }
  }

Basically, without the check to if(product_is_shippable), *all* items in the cart, regardless of their "shippability" were being added to the $pivot_element total.

Sorry, I don't know how to properly generate a patch. Hopefully somebody will be able to whip this up and get it committed.

OK. So I did a little homework and have submitted my first patch.... See attached. This patch is for Ecommerce 4.6.