The class glossary-term seems to be hard-coded in for the a link in front of glossary terms. It would be really nice if you had a text box on the options page allowing you to enter your own class for:
(a) the a link; and
(b) the abbr / acronym etc. link

I need it because I need to use a certain class name to adhere to a specific XHTML "microformat".

Comments

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Active » Fixed

Committed to 6.x-1.x-dev. Please try it when it's available and let me know.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Assigned: Unassigned » nancydru
fletchgqc’s picture

fletchgqc commented
Status: Fixed » Needs review

Thanks for adding it. Some code is missing. Try this at line 390, it worked for me:

$ins_before .= '<'. $replace_mode .' title="'. check_plain($term_title) .'" class="'. $term_class .'">';

This one change would make me happy, but as general advice...

I noticed that at line 387 you add class "glossary-term" to the link for abbr / cite etc, and at line 398 you add the user specified class (term_class) to the link for the hovertip.

Perhaps you need two boxes on the admin page: one is "class to add to 'a' elements" (in more user-friendly language), and one is "class to add to 'abbr' / 'cite' elements". They could both default to glossary-term.

Adding another class to the hovertip span may muck things up though (you'd have to check)... maybe it's all too confusing and you should just make the one fix I mentioned above until someone complains!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

IIRC, the hovertip class is required.

As for missing the the abbr/acronym/cite class, all I can plead is my illness which is making it hard to concentrate for more than a few seconds. I'll be really glad when it's gone.

Committed to -dev.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Needs review » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.