Closed (fixed)
Project:
Messaging
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 May 2008 at 07:30 UTC
Updated:
22 May 2008 at 15:12 UTC
On admin/settings/messaging/edit/notifications-event, you can't delete a non-default message part (e.g., Subject) once it is defined. If you click Save, it doesn't.
Patch:
diff -u -r1.1 -r1.2
--- messaging.module 7 May 2008 07:15:28 -0000 1.1
+++ messaging.module 7 May 2008 07:19:32 -0000 1.2
@@ -1,5 +1,5 @@
<?php
-// $Id: messaging.module,v 1.1 2008/05/07 07:15:28 cvsroot Exp $
+// $Id: messaging.module,v 1.2 2008/05/07 07:19:32 cvsroot Exp $
/**
* Drupal Messaging Framework
*
@@ -248,9 +248,9 @@
$group = $form_values['group'];
foreach ($form_values['messages'] as $key => $messages) {
foreach ($messages as $method => $text) {
+ // Save
+ db_query("DELETE FROM {messaging_message_parts} WHERE type = '%s' AND msgkey = '%s' AND method = '%s'", $group, $key, $method);
if ($text = trim($text)) {
- // Save
- db_query("DELETE FROM {messaging_message_parts} WHERE type = '%s' AND msgkey = '%s' AND method = '%s'", $group, $key, $method);
db_query("INSERT INTO {messaging_message_parts} (type, msgkey, method, module, message) VALUES('%s', '%s', '%s', '', '%s')", $group, $key, $method, $text);
}
}
Comments
Comment #1
jose reyero commentedFixed, thank you.
Comment #2
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.