I have ported Goofy to Drupal 6. The attachment is a patch to revision 1.22, the latest version in HEAD, that brings it to D6.

It also needs an info file, for which I can't create a patch since it doesn't exist yet, so here it is:

;
; Goofy port for Drupal 6
;
; @see http://drupal.org/project/goofy
; From the project page:
; PHP-based theme by Steven Wittens (UnConeD) - "Colourful, graphical, orange theme for high-resolutions."
;
;

name = Goofy
description = Colourful, graphical, orange theme for high-resolutions.
Distributed with Drupal core 4.6/4.7.
;screenshot = screenshot.png
version = 6.1
core = 6.x

; Goofy is a plain PHP theme
;engine =

; Goofy only has two regions
regions[left] = Left sidebar
regions[right] = Right sidebar

features[] = logo
features[] = node_user_picture
features[] = comment_user_picture
features[] = favicon

; Goofy does not implement the following features
;features[] = name
;features[] = slogan
;features[] = mission
;features[] = search
;Goofy only includes primary links, no secondary
;features[] = primary_links
;features[] = secondary_links

; Goofy only uses the implicit stylesheet
;stylesheets[all][] = style.css

; Goofy does not use JS
;scripts[] = script.js

; Actually, it probably does not even require PHP5
php = DRUPAL_MINIMUM_PHP

CommentFileSizeAuthor
#2 goofy.theme_.patch6.97 KBfgm
goofy.patch7.05 KBfgm

Comments

Mark Theunissen’s picture

Thanks! I will definitely be looking into upgrading my site once Views/CCK is ready for 6, at which time I'll give you feedback on how the theme looks as opposed to the 4.7 version.

fgm’s picture

StatusFileSize
new6.97 KB

Slightl improvement: this new version removes some PHP warnings due to the stricter requirements of D6.

Mark Theunissen’s picture

Any chance of getting a release created for 6.x ?

Mark Theunissen’s picture

Hi fgm, I have tested this patch but get the following error:

warning: array_key_exists() [function.array-key-exists]: The second argument should be either an array or an object in /Users/mark/WWW/dscouts-6.5/sites/all/themes/goofy/goofy.theme on line 412.

Something to do with the goofy_links() function?

Mark Theunissen’s picture

Fixed it. The following function definition should look like this (line 287 of goofy.theme):

function goofy_comment($comment, $node, $links = array()) {

Note the extra '$node' in the middle.

Mark Theunissen’s picture

Status: Needs review » Reviewed & tested by the community
Mark Theunissen’s picture

Status: Reviewed & tested by the community » Needs work

Sorry for the many small comments here. Found another issue. In your patch, you change

$img_path = base_path() . path_to_theme() .'/images/';

to

$img_path = drupal_get_path('theme', 'goofy') .'/images/';

on line 208 of goofy.theme. Any reason? It causes an invalid path in my testing (because drupal_get_path doesn't output the base_path part).

fgm’s picture

It is indeed re-modified in a more recent version I've made of Goofy 6, but not yet committed.

fgm’s picture

Version: master » 6.x-1.x-dev
Status: Needs work » Fixed

I just committed the initial D6 version.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.