on the admin/logs/status page I got the following error/warning after having upgraded from 5.x-2.2 to 5.x-2.3:

* warning: Missing argument 2 for clone_help() in .../sites/all/modules/node_clone/clone.module on line 8.
* warning: Missing argument 2 for clone_help() in .../sites/all/modules/node_clone/clone.module on line 8.

Because I have no idea under what circumstances this second argument to clone_help may appear or not I made this second argument optional, see the patch attached.

CommentFileSizeAuthor
#3 node_clone.5.x-2.3-2.patch639 bytesblackdog
node_clone.5.x-2.3.patch653 bytesschoene_idee

Comments

schoene_idee’s picture

schoene_idee commented
Status: Active » Needs review
jsimonis’s picture

jsimonis commented

I received the same error.

blackdog’s picture

blackdog commented
StatusFileSize
new node_clone.5.x-2.3-2.patch639 bytes

hook_help doesn't take more than one argument, see the API documentation.

I've just removed the second argument completely in schoene_idee's patch.

andyhu’s picture

andyhu commented

I think the problem is 5.x-2.3 is not really a 5.x module, it only works in drupal 6. See menu hook and compare to 5.x menu system....

pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

sorry- I made a mistake when tagging the files- please use 5.x-2.4 instead: http://drupal.org/node/256805

pwolanin’s picture

pwolanin commented
Status: Fixed » Closed (fixed)