Reorganize menu items
mustafau - May 7, 2008 - 17:51
| Project: | FeedAPI |
| Version: | 6.x-1.x-dev |
| Component: | User interface |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | patch (code needs review) |
Description
"FeedAPI Settings" page doesn't fit under "admin/settings/". It should be moved to a tab under "admin/content/feed/".
Patch is attached.
#1
Patch was lost.
#2
Well, why? I have seen that for example simpletest uses the same location for settings, coder module too.
#3
SimpleTest and Coder uses built in Drupal permissions for access to their settings pages (SimpleTest uses 'access administration pages'; Coder uses 'administer site configuration').
FeedAPI's approach is different. It uses it's own permissions ('administer feedapi'). FeedAPI is like core aggregator. Core aggregator's settings page is under 'admin/content/aggregator/settings' and it uses 'administer news feeds' permission.
#4
This is what I would like to see the menu hierarchy as:
admin/content/feedapi (MENU_NORMAL_ITEM)admin/content/feedapi/list (MENU_DEFAULT_LOCAL_TASK)
admin/content/feedapi/import (MENU_LOCAL_TASK)
admin/content/feedapi/export (MENU_LOCAL_TASK)
admin/content/feedapi/export/opml (MENU_CALLBACK)
admin/content/feedapi/export/url_list (MENU_CALLBACK) (not implemented, just to make things clear)
admin/content/feedapi/settings (MENU_LOCAL_TASK)
#5
The patch.