"FeedAPI Settings" page doesn't fit under "admin/settings/". It should be moved to a tab under "admin/content/feed/".

Patch is attached.

CommentFileSizeAuthor
#5 feedapi_reorganize_menu.patch2.08 KBmustafau
#4 admin_page_with_local_tabs_in_action.png11.38 KBmustafau
#1 move_feedapi_admin_settings.patch4.39 KBmustafau

Comments

mustafau’s picture

mustafau commented
StatusFileSize
new move_feedapi_admin_settings.patch4.39 KB

Patch was lost.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs review » Postponed (maintainer needs more info)

Well, why? I have seen that for example simpletest uses the same location for settings, coder module too.

mustafau’s picture

mustafau commented

SimpleTest and Coder uses built in Drupal permissions for access to their settings pages (SimpleTest uses 'access administration pages'; Coder uses 'administer site configuration').

FeedAPI's approach is different. It uses it's own permissions ('administer feedapi'). FeedAPI is like core aggregator. Core aggregator's settings page is under 'admin/content/aggregator/settings' and it uses 'administer news feeds' permission.

mustafau’s picture

mustafau commented
Title: Move "FeedAPI Settings" page » Reorganize menu items
StatusFileSize
new admin_page_with_local_tabs_in_action.png11.38 KB

This is what I would like to see the menu hierarchy as:

admin/content/feedapi (MENU_NORMAL_ITEM)
admin/content/feedapi/list (MENU_DEFAULT_LOCAL_TASK)
admin/content/feedapi/import (MENU_LOCAL_TASK)
admin/content/feedapi/export (MENU_LOCAL_TASK)
admin/content/feedapi/export/opml (MENU_CALLBACK)
admin/content/feedapi/export/url_list (MENU_CALLBACK) (not implemented, just to make things clear)
admin/content/feedapi/settings (MENU_LOCAL_TASK)
mustafau’s picture

mustafau commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new feedapi_reorganize_menu.patch2.08 KB

The patch.