If you've got a form with a multiple select box, and want to test what happens when nothing is selected, drupalPost can't handle it, because the code assumed that at least one thing had been selected. This patch fixes that by checking for an empty selection.

This bug was discovered when writing tests for http://drupal.org/node/255942, and is necessary for it's tests to run.

CommentFileSizeAuthor
simpletest-fix-select-no-selection.patch1.72 KBjcfiala

Comments

boombatower’s picture

boombatower commented
Status: Needs review » Reviewed & tested by the community

This patch makes sense and two of the tests that use selects still pass so it doesn't appear break select functionality.

I haven't tested in the specific case that jcfiala is trying to fix, but the code is fairly simple and would appear to work.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

Should we include a test for this in core?

boombatower’s picture

boombatower commented

Isn't jcfiala witting a test for block stuff (http://drupal.org/node/255942) that would be included in core?

jcfiala’s picture

jcfiala commented

I did, but it won't be included, apparently, as no one else sees a use for it. I don't know of any other core instances where I could set up a test to test this fix to the test framework.

alexanderpas’s picture

alexanderpas commented

@Dries :D
we should, as a user might for example, select no taxanomies in a required taxanomy multiselect-list, and we need to check if the error is properly displayed, thus requiering this functionality, thus requiering a test as it is D7 code ;).

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.