video tabs showing up on frontapage

Added support for windows media...

It works with Internet Explorer, Mozilla Firefox + Kaffeine Plugin on Linux.

It doesn't work with Firefox on WIndows.

I need help with this.

’ve been noticing this problem of the tabs showing up on the front page with drupal CVS. It used to be the last video node that was submitted (created or edited) would have its play and download tabs show up on the front page. It’s definitely an issue with the cache because clearing the cache table and then refreshing the front page fixes it. With the latest drupal CVS version it seems to be a little better, where I can’t reproduce the problem but it still shows up every now and then. Is anyone else still noticing this problem?

the problem of the tabs showing up on the frontpage is also
present on current cvs version (1.16).

I confirm that this is a caching problem.

luke's site show it live now: http://www.ppixel.com/

This bug is really hard to reproduce. I wasn't able to do that.
Does anyone knows how can I reproduce it?

I need to reproduce it becouse after reading some drupal docs
I understood that the reason of this bug should be an incorrect implementation
of the video_menu function.

This is the current version (1.16):

function video_menu($may_cache) {
  global $user;

  if ($may_cache) {
    $items[] = array('path' => 'video', 'title' => t('videos'),
      'callback' => 'video_page',
      'access' => user_access('access video'),
      'type' => MENU_SUGGESTED_ITEM);    
    $items[] = array(
      'path' => 'node/add/video',
      'title' => t('video'),
      'access' => user_access('create video'));
    // I don't get this whole goto thing - deekayen 
    $items[] = array(
      'path' => 'video/goto',
      'callback' => '_video_page_goto',
      'type' => MENU_CALLBACK,
      'callback arguments' => arg(3),
      'access' => user_access('access video'));
  }

  if (arg(0) == 'node' && is_numeric(arg(1))) {
    $node = node_load(array('nid' => arg(1)));

    if ($node->type == 'video') {
      if (variable_get('video_displayplaymenutab', 1) == 1) {
        $items[] = array('path' => 'node/'. arg(1) .'/play',
          'title' => t('play'),
          'callback' => 'video_play',
          'access' => user_access('access video'),
          'weight' => 3,
          'type' => MENU_LOCAL_TASK);
      }
      //If the video is of type youtube and multi-file downloads aren't turned on don't show the download tab.
      if (variable_get('video_displaydownloadmenutab', 1) == 1 and (_video_get_filetype($node->vidfile) != 'youtube' or $node->disable_multidownload == 0)) {
        $items[] = array('path' => 'node/'.arg(1).'/download',
          'title' => t('download'),
          'callback' => 'video_download',
          'access' => user_access('access video'),
          'weight' => 5,
          'type' => MENU_LOCAL_TASK);
      }
    }
  }
  return $items;
}

As you can see there are some lines contained into
if($may_cache) {

}
and others outside.
I think that these outside should be moved into an else statement
for the if($may_cache) because without the else also uncacheable
items will be cached.

What do you guys think about it?

Fabio

Good work, this seems to have fixed the one case I could reproduce.

Clear cache, then load "play" page, then check home page. Before the tabs would show up on the home page after doing this, now with the patch they don't.

I've committed the changes to CVS but I'll restrain from changing this to "fixed" until someone else has a chance to test it.

Luke:
please add correct caching if and else statement also
to the video.module version for drupal 4.6

I tried it but not luky with cvs... I'm getting:
cvs commit: sticky tag `DRUPAL-4-6' for file `video.module' is not a branch

So please tell me the cvs commands you will use.
Thanks.

Fabio

I use Tortoise CVS which doesn't allow commiting to branches, it gives the same error.

also commited to DRUPAL-4-6