Drupal 6.x
rmiddle - May 8, 2008 - 00:11
| Project: | Countdown |
| Version: | HEAD |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Are you planing to upgrade this Module to Drupal 6.x?
Thanks
Robert
| Project: | Countdown |
| Version: | HEAD |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Are you planing to upgrade this Module to Drupal 6.x?
Thanks
Robert
#1
yes
#2
Ok this has to be the easiest D6 Updated I have done. The patch is really simple.
#3
#4
OK here is another 6 Patch incorporating the changes in issue "Add a theme function for the block content (http://drupal.org/node/141067)"
following the basics of his patch and moved everything from the view case to countdown.tpl.php. Added the support required to call the theme. I didn't make any other changes then that. So you can use the Patch from #2 to just do a bear bone 6 Upgrade or use this one to add theming support.
Thanks
Robert
#5
I made a mistake I added a dependency line from the info file. I misread the 5.x version and thought it required the events modules.
Thanks
Robert
#6
Please run it through coder module. I see at least one thing it would catch.
#7
I fixed all the errors in coder but they were there before I made one change to the source. I also fixed my dependence mistake as well.
Thanks
Robert
#8
#9
committed
For your future reference, anything in the .info file that was added by the Drupal packager, in this case the version string, shouldn't be added to patches or CVS. I also removed the $block stuff in the tpl file since I assume that was just leftover from the 5.x patch.
#10
Yea the $block = ""; was left in from the patch. Great.
Thanks
Robert
#11
Are you planing on doing a devel tag/Version? I see the code in CVS but don't see a package being prepared for release I am still pretty new to Drupal's release system so maybe I am just missing something?
Thanks
Robert
#12
Why did you remove the 5.x version? It is now marked "unsupported" for 5.x and one gets annoying warning messages.
#13
There is a 5-x 1.1 version there now. It looks like he marked the old version unsupported at the same time he released the new version only it seems to take a day for new versions to show up but the unsupported is right away. It should clean itself up in the next 24 hours.
Thanks
Robert
#14
Ok, thanks.
#15
Automatically closed -- issue fixed for two weeks with no activity.