By jhaggenburg on

Hey there,

I've been drupaling for a couple of days now and I've seen/heard/read a lot of podcasts and tutorials, but this still isn't clear to me.
My changes made it possible to use the terrain-option in the gmap-module and I would like to "share this with the community" :) For this to happen, I've added some nice little lines to several files (gmap_macro_builder.module, gmap_settings_ui.inc and js/gmpa.js). I've got two questions about this:

1 - Is this "hacking core" where everyone's wining about? :) How should I have done this the "drupal way"?
2 - What is the way of steps to share this with you?

I'm curios how to tackle this, so bring it on!

J.

ps: sorry for weak english, i'm from Holland.

⋅ Categories: Drupal 5.x

Comments

gpk’s picture

gpk commented

You haven't hacked core. you've hacked a contributed module ;-)

There is already a feature request for this against the gmap project - http://drupal.org/node/218687. Suggest you join in the discussion there. And possibly turn the necessary mods into a patch for the maintainer to apply to the project http://drupal.org/patch/create.

gpk
----
www.alexoria.co.uk

gpk
----
www.alexoria.co.uk

jhaggenburg’s picture

jhaggenburg commented

Yeah, I thought these files were part of the core of Gmaps for instance and should have been overridden by functions in an external file maybe? Thanks for the link, I found it out myself (not thát hard.. :) ) because I couldn't found anything about it.
Thanks, as soon as I can get some time for this, I'll make a patch. Seems to be a nice start for doing this :)