Field label change drops permissions

miro_dietiker - May 8, 2008 - 08:23
Project:CCK Field Permissions
Version:5.x-1.10
Component:Code
Category:bug report
Priority:critical
Assigned:halstead
Status:closed
Description

When changing the label of a field, all corresponding permissions are being dropped.
This kind of update is not understood as reason to check access permissions again and fields got hidden accidentally...

Why not use the field naming for permission dataset?
This is a major issue in productivity. I see no reason to use Label in this context and therefore file this as a bugreport (due to loss of information in case of a minor update).

Thanks for your opinion.

#1

halstead - May 28, 2008 - 23:49
Status:active» needs review

This fixes the issue by storing the field_name in the permissions table and form_altering the access page to display the field label.

AttachmentSize
cck_field_perms.patch 2.69 KB

#2

webchick - May 29, 2008 - 00:04
Status:needs review» reviewed & tested by the community

Confirmed that this patch fixed the problem for me.

To reproduce, I created a text field called "Moose" and assigned view permissions to authenticated users. Before the patch, renaming this field to "Moosesd87s8sd45" caused the checkbox at admin/user/access to clear. After the patch, on subsequent rename, it stayed checked. :)

#3

webchick - May 29, 2008 - 00:05
Priority:normal» critical

Also, I would call this critical. Taking away your permissions you worked so hard to setup is not nice.

#4

halstead - May 29, 2008 - 00:10
Priority:critical» normal
Status:reviewed & tested by the community» needs review

Here is a pre-patched module file for people not familiar with CVS and patch.
(The patch above was done against CVS. This module file is the version in the 5.x-1.10 download.)

AttachmentSize
cck_field_perms.module.gz 3.24 KB

#5

webchick - May 29, 2008 - 00:12
Status:needs review» reviewed & tested by the community

Oops. I'm pretty sure halstead didn't mean to reset the status here, so switching it back.

#6

halstead - May 29, 2008 - 04:19
Priority:normal» critical
Assigned to:Anonymous» halstead
Status:reviewed & tested by the community» fixed

This is in 5.x-1.x-dev which should appear soon.

#7

Anonymous (not verified) - June 12, 2008 - 04:22
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.