Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When performing CSS validation I get the error Parse Error mask() which seems to originate from nice_menus.css
ul.nice-menu li.menuparent ul iframe,
/* For Garland header. */
#header-region ul.nice-menu li.menuparent ul iframe {
display: none;
display/**/: block;
position: absolute;
top: 0;
left: 0;
z-index: -1;
filter: mask();
width: 20px;
height: 20px;
}
I don't know why filter: mask(); is needed or if it is necesery
Comment | File | Size | Author |
---|---|---|---|
#5 | css_validation.patch | 3.5 KB | davividal |
Comments
Comment #1
add1sun CreditAttribution: add1sun commentedIt is necessary for IE6 to work properly, hence why it is under the "IE 6 Fixes" comment in the code. It was added a log time ago by other folks that worked hard to get IE6 working reasonably well so I don't remember what the specific effect/use/need for that line is in particular.
Comment #2
add1sun CreditAttribution: add1sun commentedHere is a link to the basic idea that we are using filter: mask() for: http://shepherdweb.com/2007/02/14/z-index-ignored-for-select-element-in-...
I don't know of any other way to make the menu work properly in IE 6 so I'm going to mark this won't fix.
Comment #3
mskicker CreditAttribution: mskicker commentedhow can i solve this problem ?
URI : http://nrec.ir/sites/all/modules/nice_menus/nice_menus.css?c
122 ul.nice-menu li.menuparent ul iframe, #header-region ul.nice-menu li.menuparent ul iframe Parse Error mask()
Comment #4
GuillaumeDuveauFYI, some work is being done in the date module to insert this with jQuery just for IE6 : #352975: Remove filter: mask(), which breaks CSS validation
Comment #5
davividal CreditAttribution: davividal commentedI'm submitting a simple patch following the same steps as #352975: Remove filter: mask(), which breaks CSS validation.
It's working fine for me and it's validating.
EDIT: Not tested under IE, though.
Comment #6
davividal CreditAttribution: davividal commentedUpdating ticket info.
Could someone review my patch?
Comment #7
add1sun CreditAttribution: add1sun commentedBiggest problem with this is that it is altering 3rd party code, which I don't want to deal with. Seems like the real solution for date was to remove it from the module and let individuals add it back in their theme (http://drupal.org/node/352975#comment-1863336). Not sure what the best way to go is, but I am less and less inclined to deal with IE6 myself.
Comment #8
add1sun CreditAttribution: add1sun commentedI'm going to postpone this issue for now. I'm currently leaning towards removing this from the D7 version of Nice Menus with a comment about how to add it to a theme for those that wish/need to keep supporting IE6.
Comment #9
ain CreditAttribution: ain commentedSince IE6 upgrade is lobbied by Microsoft itself (e.g. through Automatic Updates) I believe that dropping the support for IE6 should be considered even sooner. If anyone is eager to still support it, they should introduce respective developments on their own.
Passing validation is becoming increasingly more important and should certainly rule out the importance of supporting non-standard legacy platforms.
Comment #10
Anonymous (not verified) CreditAttribution: Anonymous commentedWhat about putting the fixes in a separate conditional style-sheet?
Comment #11
yan CreditAttribution: yan commentedI agree with #9: In my opinion standards compliance has become more important than IE6 support. Even Microsoft encourages people not to use IE6. Or is this too much of a first world perspective?
Wouldn't #10 be the easiest solution?
Here's an interesting article about the question: http://blog.outsidethebox.co.uk/post/IE6-vs-Standards-Compliance.aspx
Comment #12
yan CreditAttribution: yan commentedHm, some months passed by and still nothing changed. Wouldn't #10 be the best solution for now?
Comment #13
add1sun CreditAttribution: add1sun commentedI'm moving this to D7 and we will remove the IE code altogether. We'll add documentation for folks to manually add the CSS they need for IE6 if they want. If someone *really* wants a fix for this in D6 that doesn't involve removing the code, then you'll need to supply a working patch for review.
Comment #14
mdlueck CreditAttribution: mdlueck commented+1 vote for #10.
'tis the only error reported by the Web Developer toolbar in Firefox on our Drupal sites which use Nice Menus.
I do not mind running on a custom fork of this mod. Anyone with suggestion how to implement #10?
Comment #15
add1sun CreditAttribution: add1sun commented@mdlueck, you don't need to support a fork. As I said in #13, if you want the feature in the module, feel free to supply a patch, and we'll review it and put it in if it works well for the module. I just don't have time to figure it out and write a patch myself. Patches are always welcome.
Comment #16
mdlueck CreditAttribution: mdlueck commented@add1sun: Good to know you are open to such a contribution.
Thus all that remains is the last part of my #14 post... "Anyone with suggestion how to implement #10?"
Comment #17
mdlueck CreditAttribution: mdlueck commentedI just happened to spot this on a site built with Drupal:
So is IE really smart enough (gasp!) to obey that sort of conditional? In my mind, this is the sort of thing I was thinking of to fix this problem.
Comment #18
add1sun CreditAttribution: add1sun commentedYep, conditional comments are the standard way to get IE to behave with different CSS and a patch to do this would require setting the conditional in the module rather than the theme, where most people do it.
Comment #19
mdlueck CreditAttribution: mdlueck commentedBut in the mod itself would have the logic self contained. Patching it in the theme leaves it up to each person implementing the mod.
Perhaps I will try that conditional design and see if I can make it work.
Comment #20
bfroehle CreditAttribution: bfroehle commentedHow about using conditional_styles? Seems like a no-brainer to me.
Edit: Does that work with modules? Or only themes?
Comment #21
bfroehle CreditAttribution: bfroehle commentedSee http://drupal.org/node/1031344 and drupal_add_css() and, for example, bartik_preprocess_html().