Re-do Spansih translation

marvil07 - May 8, 2008 - 16:59
Project:Organic groups
Version:5.x-7.2
Component:og.module
Category:feature request
Priority:normal
Assigned:marvil07
Status:patch (code needs review)
Description

I've made a translation of OG uptated to 7.1.

I really do not know if this issue is a patch (code needs review), but I mean needs review :D.

This file is before #255934: Some translations issues patches.

AttachmentSize
og-7.1-es.po71.93 KB

#1

moshe weitzman - May 8, 2008 - 19:52

you are welcome to commit this yourself after perhaps waiting for feedback. i don't think the module maintainer has to commit translations like he does code.

#2

marvil07 - May 9, 2008 - 14:15

@moshe: ok, thx for the guidelines

#3

hass - May 9, 2008 - 18:31
Status:patch (code needs review)» patch (code needs work)

There are new POT files... check it out. This requires splitted .po files as there are some duplicate strings and POTX must run with --mode=multiple to be save.

#4

marvil07 - May 14, 2008 - 12:23
Assigned to:marvil07» Anonymous

#5

develCuy - May 15, 2008 - 17:23

@marvil07, This is a quick review of your translation. Basically, try to preserve Organic Groups name as is or Translate all occurrences, having both is confusing, I'm not sure how translation in other languages fight with that issue, perhaps @moshe knows.

Blessinsg!

AttachmentSize
og-7.1-es.po72.13 KB

#6

marvil07 - May 28, 2008 - 21:51

Applying develcuy suggestions(the problem was the comments and mail strings changed accidentally) and improving a lot of strings.

AttachmentSize
og-7.1-es_v2.po71.98 KB

#7

marvil07 - June 3, 2008 - 13:29
Version:5.x-7.1» 5.x-7.2
Assigned to:Anonymous» marvil07
Status:patch (code needs work)» patch (code needs review)

Starting from this revision and using drupal-contrib l10n server I made a 7.2 version.

Now, like hass suggest it's splitted in some files with the Flat package for CVS commit option of the l10n server module. In the attachment there are these files:

  • general.po
  • includes.po
  • root.po
  • tests.po
  • translations/
    • installer.es.po

So, my question now is how to organize it to commit them.

I have not seen so many files per language in po/ directory on OG. Do I miss something?

I believe renaming them as .es.po it's a good idea, for example general.es.po.

@moshe: I wait for recommendation.

AttachmentSize
og-5.x-7.2-es-translations-flat.tar_.gz20.93 KB

#8

hass - June 3, 2008 - 16:11

See http://ftp.drupal.org/files/projects/og-5.x-1.x-dev.tar.gz how I named the German files after POTX generated the POT files for me. I'm not sure what export option is this in l10n_server...

#9

moshe weitzman - June 3, 2008 - 16:32

I have no idea how to organize this. I would like to follow how other leading modules do it (CCK, Views, votingapi/fivestar, ...)

#10

marvil07 - June 4, 2008 - 01:31

I've taken a look to the translations of the modules you mentioned.

A little summary:

The majority of the modules use one big single PO file <language_code>.po, including:

  • cck-5.x-1.7
  • fivestar-5.x-1.12
  • views-5.x-1.6
  • fivestar-6.x-1.12
  • views-6.x-2.0-beta3

VotingAPI(5.x-1.6 and 6.x-2.0-beta3) don't have translation :|

The only one module(I found) that use more than one PO file to translate is cck-6.x-2.0-beta, which have one translation(de) in three files in the following format: <filename>.<language_code>.po, like examples.de.po

I think it's a good idea to follow i10n_server flat format using the files generated by that module, in <filename>.<language_code>.po format.

#11

hass - June 4, 2008 - 06:28

1. if you have submodules like CCK you should split per submodule. This allows to import only strings for modules that are really used and does not import every unsused translations. This is how it should be.

2. Another issue that came up with OG is a issue i reported at #219007: Poedit reports duplicate message definition. And this is why we have splitted files in OG.

#12

develCuy - June 4, 2008 - 13:45

@marvil07, my apologize, l10n_server may confuse because it suggest an export for CVS commit, but this works for core, not for contributed modules. So please dismiss my suggestion.
I strongly recommend to read the Translator's guide.
OG is splitted different in the "he" language code, perhaps because they have a translation team and are fighting with the Poedit issue. Now that @marvil07 is working with the l10n_server which avoids dupes, provides "ready to go" .po files, and interface to collectively colaborate. So... there is no need to split the spanish traslation IMHO.

Blessings!

#13

hass - June 4, 2008 - 14:32

@develCuy: have you read my comment #11?

#14

Gábor Hojtsy - June 7, 2008 - 08:39

First I don't understand why are you not collaborating with the existing Spanish translation as linked from the l10n_server page: http://l10n.drupal.org.es/

Second: general.po, includes.po, root.po, tests.po are not for different modules, so I'd suggest you merge them (after you started collaborating with the existing spanish translation team).

#15

hass - July 12, 2008 - 13:48

The duplicate string issue seems not exists in your files. Not sure why. I'm going to merge the German files back together as I hopefully found the bug of #219007: Poedit reports duplicate message definition.

 
 

Drupal is a registered trademark of Dries Buytaert.