Update for Drupal 6?

I can't speak on behalf of webchick, the developer of this module, but I'm not planning to port this module on a short term. So anyone who wishes to jump on the port, it might be the perfect way to learn how Drupal works. All you need to know about the D5->6 changes are described here: http://drupal.org/node/114774

Have you tried already to run it yourself on D6? I don't know whether you are a PHP developer, but perhaps you can give it a try and post your findings?

HEAD has a 6.x port already. Needs testing.

Please excuse my ignorance, but where can I find this port? I don't see it listed under development snapshots on the project page.

It's not. it needs to be checked out from CVS.

First test of the port : I have error messages because I use the Views module:

  * warning: include_once(sites/default/modules/revision_moderation/revision_moderation_views.inc) [function.include-once]: failed to open stream: No such file or directory in /etc/drupal/default/modules/revision_moderation/revision_moderation.module on line 14.
    * warning: include_once() [function.include]: Failed opening 'sites/default/modules/revision_moderation/revision_moderation_views.inc' for inclusion (include_path='.:/usr/share/pear:/usr/share/php') in /etc/drupal/default/modules/revision_moderation/revision_moderation.module on line 14.

revision_moderation_views.inc is indeed absent of the repository. maybe someone forgot to upload it?

anyway, after commenting out lines 13, 14 and 15 in revision_moderation.module, this message disappears. Is this file really necessary?

Oh, crumb.

Yes, this makes sense because at the time, views wasn't ported to 6 yet.
However, it should not be including files that don't exist. ;)

The best option would be to port views.inc to 6, obviously. Failing that though, we definitely should remove those lines so they're not causing errors.

Would you be able to roll a patch?

Here is the patch commenting the offending lines. It also adds a CR at the end of the file (diff complains about it)

about the implementation of the missing file, what functionality is missing if this file is not ported? I can hardly see the relationship between revision moderations and the views module...

I think the only thing the views.inc file adds is a filter so that you can build a list of nodes that have pending revisions, which actually is kinda nice.

I've marked this for code needs work, because we should actually fix views.inc, but I'll commit this within the next couple of days as an interim solution.

What about this?

http://drupal.org/node/198587

I was asked about this on IRC tonight. Here's WAY more information than you ever wanted to know. ;)

My larger plans with this module are to get a modified version of it and modr8 module into core for D7 (or possibly D9 ;)) and restore Drupal's ability to handle content moderation natively, which was ripped out in D5.

However, this module was written for a client in the 4.7.x era, which I ported to 5 because I found myself once with a couple free hours on a weekend and nothing better to do. Since we no longer are working with said client, and since I don't have enough time with all my other Drupal responsibilities to do anything as silly as actually make my *own* sites with Drupal, it's not at all on my radar for dealing w/ anytime soon. This module is basically in "triage" mode, and I've just been looking at patches that are RTBC where it look like a few people have tried them.

However, that said, cwgordon7 has already ported the basic module to 6 back in Jan/Feb as a GHOP task, and this code is in the HEAD version. I haven't rolled any releases because:

* the Views integration isn't there, and needs to be, since the default block/page the module provides is not very smart.
* core actions integration is also very important, as that allows you to integrate this module with Workflow, and I can't remember if that's there or not since it's been a few months since I looked at it.
* Workflow-NG was added to the D5 module after the port took place, and no one's been by to port that to D6 yet. I have no idea how to port this, but IMO, this is not release-critical anyway.

I'm willing to give the keys to this module away to anyone who gets the D6 version working, because it'll likely be several weeks before I have an opportunity, since I have 100,000 irons in the fire, all of which are of much higher priority than this for me right now.

The only thing that I ask is that if you do decide to work on this/take the module over, PLEASE resist turning it into a "every moderation use case" module NOR a "fix everything wrong with the core revision system" module, and keep it strictly to what it does which is leaving the original version of the node published when new ones are created.

Hi,

This is my patch, based on cvs 5.1.0. Used cwgordon7's patch for actions.

Also added a hook cron (can be disabled) to delete old revisions.

@ makara

Is this patch related to the Drupal 6 port? It's not that obvious to me at first sight.

Second, I would like to make a remark about the cron function you added. "Also added a hook cron (can be disabled) to delete old revisions."
I would propose you open a new issue for that as it is a new feature and is not related to the Drupal 6 port. I even question whether it is related to the revision moderation module. Perhaps it can better live as a contrib module as the whole point of storing revisions is to keep the history.

I am also very keen to have this module for D6. I am not a developer, but if I can help with testing, please point me to where I can download from.

@makara - after applying your patch (to version 5.1.0) it works perfect for me in drupal 6, thanks!
I have rerolled it to apply for head, probably needs more testing though.

changing status

Patch is good except for one thing... it didn't work :(

After reading through the source code for a while, i found the cause was a missing } on line 153.

thanks, fixed :)

@westwesterson: Want to inherit another webchick special? ;) I've been sorely neglecting this poor module.

@webchick - i can't promise i'll be much better at updating the module than you have been, i don't have many plans for this besides updating the module to 6.x, if no one else steps up i'll do it though, this module is important.

on that note heres a patch without the .project junk at the end this time.

Added you to the list of CVS maintainers. Please feel free to commit it and roll a release when you feel it's ready.

awaiting a tester, to review before I can commit this.

committed this to head, please put further bugs in separate issues.

I use the cck imagefield for D6 and if admin decide to delete the new revision the image gets lost and forgotten by the node.

@pingvinen: best practice is to open a new issue.
This issue is closed and was regarding the port to D6.