Closed (fixed)
Project:
Panels
Version:
5.x-2.0-beta3
Component:
Panel pages
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
9 May 2008 at 07:43 UTC
Updated:
23 May 2008 at 21:48 UTC
Jump to comment: Most recent file
Comments
Comment #1
sdboyer commentedSo I burned several hours into this last night and came up with a patch that's more or less working. There's a little more to this than just adding another widget to that form - I had to expand the parameters for panels_edit_layout_settings(), add a new db field, and at some point am going to have to really think through and rework the system panels_pages uses for determining page titles. Then there's the OO rewrite...well, there's plenty to do. In any case, though, modifications allowing the user to assign titles that are specific to alternate panels_page displays have been committed and will be available as of beta4.
Note that I wouldn't run -dev - I'm makin changes at a pretty quite rate, so I really can't guarantee the stability of -dev. If you're really intent on having this, I can look for some time to roll a patch that's specific to those changes.
Comment #2
patchak commentedsdboyer: thanks!!! that's an awesome feature to use panel pages as a complete replacement for taxonomy/term pages and even node display!!
If you could roll a patch so that I could use this feature before beta 4 I would really appreciate it!!
Thanks again,
Patchak
Comment #3
sdboyer commentedOK, so, I forgot something about this patch before I wrote that - handling this new functionality requires a database change, and because I'm not sure that update_5216 is necessarily done, it means that the only way you'll safely be able to use this before release is if you take some icky database steps both now and when you upgrade to beta4 later.
Here 'tis: execute the following mysql command against your desired db:
ALTER TABLE panels_display ADD COLUMN title varchar(128);(you are on MySQL, right? If not, shift it over to the pgsql syntax)When you update to beta4, you're going to want to find the corresponding line in the panels.install file and delete it BEFORE running update.php, then put it back in place afterwards (just to make sure your version is entirely in sync with the current release). Truth be told, you should be fine trying to re-add the same table field twice, but I wouldn't want you to risk it.
That aside, here's a rough patch of the changes you'll need to get this working. This probably includes a little more than what you actually need, but it oughtn't break anything. Please do let me know if you run into any bugs, or have suggestions as to how to improve it, as I'm not very happy with this functionality as it currently stands. Note also that you'll still see the 'generated' titles on the alternate displays on panels_page admin editing screens; the special-input one you add in layout settings will only show up when the page is actually being rendered.
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #5
patchak commentedThis seems to work I will test more this weekend!!
Comment #6
sdboyer commentedThese changes have already been committed (and there are probably fifty commits at least between then and now), but gusaus and NiKLP have reported some problems related to it (though not directly resulting from it per se, at least as I understand thus far) in #261622: Missing TITLE tag in node override. Being that I'm pretty sure that this patch itself isn't actually broken, I'm going to keep this closed and focus on that issue instead.