The 'Next' button (when being guided through the creation of a new Panel) implies that changes would not be saved until the final step. However, in all instances in display_edit.inc, panels_mini.module and panels_page.admin.inc this is not the case, the input is rather saved rightaway.
Therefore we should replace the 'Next' buttons by something like 'Save and proceed'. Maybe someone has a better name for that?

CommentFileSizeAuthor
#2 panels-DRUPAL-5--2.save-proceed.patch4.46 KBsun

Comments

sdboyer’s picture

sdboyer commented

Could you toss out some line numbers from the -dev version? It'd save me having to dig around for the ones you mean in particular. As I said in #256677: Some improvements for the Import pages, changing the defaults on SOME of those submit buttons constitutes an API change.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 5.x-2.x-dev » 5.x-2.0-beta3
Status: Active » Needs review
StatusFileSize
new panels-DRUPAL-5--2.save-proceed.patch4.46 KB

Agreed. I didn't know whether Panels saves my input until I found this issue.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Version: 5.x-2.0-beta3 » 5.x-2.x-dev
Status: Needs review » Reviewed & tested by the community

Thanks sun!
I tested the patch, and it works well and doesn't break anything.
RTBC?

sdboyer’s picture

sdboyer commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks for the patch, sun. Forgive the broken record, but with our $_POST-sniffing fun in panels, changing #submit values can err close to the side of an actual API change. Of course, these are in client modules, and that largely only applies to the core API...

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.