Active
Project:
World Clock
Version:
6.x-2.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 May 2008 at 15:13 UTC
Updated:
18 Dec 2008 at 18:37 UTC
After a brief review of your JS code, I noticed you are not taking advantage of the jQuery library function calls (i.e. using getElementById instead of $()).
I wonder if you considered integrating this existing plugin in the new 2.0 version you are developing: http://plugins.jquery.com/project/jclock
Thanks for your hard work,
Francesco
Comments
Comment #1
pixture commentedI originally developed worldclock.js for the web site that does not use jquery nor any JS libraries.
That's one of the reasons. And the other reason is simply I am not familiar with jquery.js. I am interestred in and would like to learn to use it if it would make things much simpler and easier. Right now, I am more focusing on the new feature of release 2.x, which are
1) Use of MySQL DB for storing and loading location list.
2) Capability of full editing location list
3) Importing/Exporting location list (so that you can give, reuse the editing location list at some other places).
4) Others
When I have time, I will start learning a bit about jquery.
Thanks for the suggestion.
Comment #2
flevour commentedComment #3
reaneyk commentedI don't know if I would necessary want to see a new jQuery plugin dependency added to the project, although having the JavaScript rewritten to take advantage of the jQuery library that is a part of the Drupal 6 core would be a cleaner way to implement the code.
Comment #4
flevour commentedThanks for the pointer, it reminds me I hadn't considered licensing problems before and always thought of including the file with the distribution. we need to have a look at that plugin license and see if we can include it or not.