Display search help based on type

douggreen - May 9, 2008 - 16:46
Project:Drupal
Version:7.x-dev
Component:search.module
Category:feature request
Priority:normal
Assigned:douggreen
Status:needs work
Description

LIVE FROM THE MINNESOTA SEARCH SPRINT, a little usability patch that gets it's help from the type argument, so that node search displays one help message and user search displays another. The hard coded HTML <UL> is also replaced with theme('item_list')

The idea for this patch comes from #247482, however we take a different approach here.

AttachmentSizeStatusTest resultOperations
searchhelp.patch3.97 KBIdleFailed: Failed to apply patch.View details | Re-test

#1

douggreen - May 9, 2008 - 16:51

Please review the verbage in user_help 'search#noresults'. If you have ideas for clearer wording here, please let us know. Thanks!

#2

Souvent22 - May 9, 2008 - 17:26

Updated patch with a simple test case that tests that a module which implements hook_search implements the hook_help for search#noresults.

AttachmentSizeStatusTest resultOperations
searchhelp.patch5.06 KBIdleFailed: Failed to apply patch.View details | Re-test

#3

robertDouglass - May 9, 2008 - 22:19

Tracking

#4

douggreen - May 10, 2008 - 20:08

Updating the test case.

AttachmentSizeStatusTest resultOperations
256678.patch5.18 KBIdleFailed: Failed to apply patch.View details | Re-test

#5

gpk - May 15, 2008 - 08:22

Have updated the 2nd line of verbage in user_help 'search#noresults', hope it's clearer.

AttachmentSizeStatusTest resultOperations
256678.patch5.2 KBIdleFailed: Failed to apply patch.View details | Re-test

#6

lilou - September 1, 2008 - 20:16

Re-roll #5 against HEAD.

AttachmentSizeStatusTest resultOperations
256678_6.patch5.19 KBIdleFailed: Invalid PHP syntax.View details | Re-test

#7

appel - October 8, 2008 - 11:27

Subscribing.

#8

Anonymous (not verified) - November 11, 2008 - 20:05
Status:needs review» needs work

The last submitted patch failed testing.

 
 

Drupal is a registered trademark of Dries Buytaert.