Download & Extend

Display search help based on type

Project:Drupal core
Version:7.x-dev
Component:search.module
Category:feature request
Priority:normal
Assigned:douggreen
Status:closed (duplicate)

Issue Summary

LIVE FROM THE MINNESOTA SEARCH SPRINT, a little usability patch that gets it's help from the type argument, so that node search displays one help message and user search displays another. The hard coded HTML <UL> is also replaced with theme('item_list')

The idea for this patch comes from #247482, however we take a different approach here.

AttachmentSizeStatusTest resultOperations
searchhelp.patch3.97 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch searchhelp.patch.View details | Re-test

Comments

#1

Please review the verbage in user_help 'search#noresults'. If you have ideas for clearer wording here, please let us know. Thanks!

#2

Updated patch with a simple test case that tests that a module which implements hook_search implements the hook_help for search#noresults.

AttachmentSizeStatusTest resultOperations
searchhelp.patch5.06 KBIdleFailed: Failed to apply patch.View details | Re-test

#3

Tracking

#4

Updating the test case.

AttachmentSizeStatusTest resultOperations
256678.patch5.18 KBIdleFailed: Failed to apply patch.View details | Re-test

#5

Have updated the 2nd line of verbage in user_help 'search#noresults', hope it's clearer.

AttachmentSizeStatusTest resultOperations
256678.patch5.2 KBIdleFailed: Failed to apply patch.View details | Re-test

#6

Re-roll #5 against HEAD.

AttachmentSizeStatusTest resultOperations
256678_6.patch5.19 KBIdleFailed: Invalid PHP syntax.View details | Re-test

#7

Subscribing.

#8

Status:needs review» needs work

The last submitted patch failed testing.

#9

Status:needs work» closed (duplicate)

This is a duplicate of #569398: Make 'no results' configurable text

nobody click here