Some translatable strings are broken, because usage of t() is incorrect. This patch fixes it.

CommentFileSizeAuthor
#1 download_count_3.patch.txt4.59 KBTakafumi
download_count_1.patch.txt2.43 KBTakafumi

Comments

Takafumi’s picture

Takafumi commented
StatusFileSize
new download_count_3.patch.txt4.59 KB

Updated patch in order to improve translatability with 'xx days xx min ago' and 'view xxx-type'.

Chill35’s picture

Chill35 commented

I wrote down the sweetest thank you note to you here, and had to restart my NET connection, and closed down the window... arghh...

Greatest patch in the world, thank you so much.

Great use of t(). I understand t() now. Last year, I obviously did NOT.

Nice touch with the human-readable node type name, too.

Now I should go back and change my Drupal 5 version to bring these improvements...

Check out the latest release. I also fixed important bugs in it. Added a JOIN between the files and the upload tables on the 'fid'. No longer am I confusing the description of the file with its filename.

Takafumi’s picture

Takafumi commented
Status: Needs review » Fixed

Great!

But, I forgot to include an escape character for double quote in Japanese translation. Japanese translation was updated now.
Please give "DRUPAL-6--1-2" tag to ja.po.

Thanks.

Takafumi’s picture

Takafumi commented
Category: bug » support
Status: Fixed » Active

status/category changes

Chill35’s picture

Chill35 commented

The next release 6.x-1.3 should contain your fix.

Let me know if it doesn't.

:-) and thanks again.

Takafumi’s picture

Takafumi commented
Status: Active » Closed (fixed)

Thanks, fine.