Download & Extend
Download Count » Issues

Some translatable strings are broken

Posted by Takafumi on May 10, 2008 at 2:54pm
Project:Download Count
Version:6.x-1.x-dev
Component:User interface
Category:support request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Some translatable strings are broken, because usage of t() is incorrect. This patch fixes it.

AttachmentSize
download_count_1.patch.txt2.43 KB
Login or register to post comments

Comments

#1

Posted by Takafumi on May 11, 2008 at 9:41am

Updated patch in order to improve translatability with 'xx days xx min ago' and 'view xxx-type'.

AttachmentSize
download_count_3.patch.txt 4.59 KB

#2

Posted by Chill35 on May 24, 2008 at 5:50am

I wrote down the sweetest thank you note to you here, and had to restart my NET connection, and closed down the window... arghh...

Greatest patch in the world, thank you so much.

Great use of t(). I understand t() now. Last year, I obviously did NOT.

Nice touch with the human-readable node type name, too.

Now I should go back and change my Drupal 5 version to bring these improvements...

Check out the latest release. I also fixed important bugs in it. Added a JOIN between the files and the upload tables on the 'fid'. No longer am I confusing the description of the file with its filename.

#3

Posted by Takafumi on May 24, 2008 at 7:56am
Status:needs review» fixed

Great!

But, I forgot to include an escape character for double quote in Japanese translation. Japanese translation was updated now.
Please give "DRUPAL-6--1-2" tag to ja.po.

Thanks.

#4

Posted by Takafumi on May 24, 2008 at 7:59am
Category:bug report» support request
Status:fixed» active

status/category changes

#5

Posted by Chill35 on May 27, 2008 at 5:04am

The next release 6.x-1.3 should contain your fix.

Let me know if it doesn't.

:-) and thanks again.

#6

Posted by Takafumi on May 27, 2008 at 1:57pm
Status:active» closed (fixed)

Thanks, fine.