Test Coverage for search_simplify

Reviewed, looks good to me.

+       '10102008' => '10-10-2008',
+       '10102008' => '10/10/2008',
+       '10102008' => '10.10.2008',

This won't work. array keys are unique.

Try reversing the array.

So that we don't run into more cases in the future like dmitrig01 found, I'd switch the key and value in the array so that it's initial => expected.

Agreed.

Re-rolled, switching array to initial => expected.

Be careful when you apply this patch to make sure that you don't lose the multibyte characters. I first applied it by copying the patch from my web browser (which is what I always do), and it failed the three CJK tests. However after downloading the patch using wget, it applied and passed all tests.

I also reviewed the code, and think that it's mostly ready to go. I'm one of the worst when it comes to commenting, so I'm not exactly sure what our standard is. But if I would add anything, it's that your comments aren't fully sentences and probably should be. You might get asked to change comments like "String to lowercase." to full sentences such as "Test simplification of strings to lowercase characters."

The patch applies fine and the tests run OK, but Doug's right on the comments, they need fleshing out to full sentences.

Setting to Needs Review so the test bot can test the last patch up there. See #11, status should actually be needs work.

We actually now have a comprehensive search_simplify() test case in modules/search/search.test.
#604002: Poor search support of some Unicode scripts