search results outputting flash parameters musings
rpmute - May 11, 2008 - 02:51
| Project: | SWFObject API |
| Version: | 5.x-2.0-beta1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
wondering if you have any thoughts on what to do when flash content comes up in search results. its a bit annoying. check the attachment. im going to look into just outputting the node title but it'll be don't know if that'll be just a drupal fix for my site only or if site engines like google are reading everything as well.
| Attachment | Size |
|---|---|
| searchresults.gif | 7.45 KB |
#1
This is really an issue with the search engine and we should filter these out.
But the solution is to put all your script code inside an HTML comment. This is what we had to do in the 1990's when some browsers didn't support script. And I think it's still good practice.
<script><!-- --></script>See #257196
#2
doug: thanks. i still don't know what i'm doing though.
wrapping the $content variable in:
<div class="content"><script><!--
<?php print $content; ?>
--></script>
</div>
the player should be the only thing in $content. everything else is taken care of with cck and output in panels2. so....
#3
I think that the bug is in swfobject_api.module on line 158, they need to put the javascript inside a comment.
This also seems to be a bug in Drupal core, and I'm addressing that in #257196.
#4
I'll take care of this and roll a new release
#5
Please follow the other thread and make sure that this works, before rolling it in here. Thanks!
#6
OK, sorry, ignore comment #5, that is the solution. #257196 is now CNR.
#7
I've added a fix to DRUPAL-5 version of swfobject- can you give that a try and see if that fixes your problem?
#8
yeah, dl'ed the imageapi 5.x-1.x-dev release. seems to be working fine now when i do a search. the js code is gone. thanks.
the video doesnt show up though with this version, so i'll still use swfobject_api-5.x-1.2-15.tar.gz for now.
#9
This should be resolved with the new approach to rendering the player