Node Links Ranking Addition

I don't like that there are up to 3 extra queries on every node that gets indexed, especially if this ranking isn't used.

I'd have a look at putting something like this in search_update_totals:

if (variable_get('node_rank_link', 0)) {
  $dirty = search_sid_dirty();
  $placeholders = db_placeholders($dirty);
  db_query("DELETE FROM {search_node_link_totals} WHERE type = 'node' AND sid IN ($placeholders)", $dirty);
  db_query("INSERT INTO {search_node_link_totals} SELECT sid, type, count FROM {search_node_links} WHERE type = 'node' AND sid IN ($placeholders) GROUP BY sid, type", $dirty);
}

The search_sid_dirty() function doesn't exist. I suspect that this will be useful so that the DELETE and INSERT only affect a dozen nodes instead of ALL of them.

Notice that I'm only doing the update if the node_rank_link is used. Because of this, you'll need to do two more queries when the node_rank_link gets set to something other than 0, maybe in a submit handler from a form_alter?

db_query("DELETE FROM {search_node_link_totals}");
db_query("INSERT INTO {search_node_link_totals} SELECT sid, type, count FROM {search_node_links} WHERE type = 'node' GROUP BY sid, type");

Minor, but at least one code comment does not end in a full stop (period).

I have no real comment on the patch regarding post #2, Doug is in a much better position to evaluate its merits.

However, the attached patch makes the following changes from the previous patch:

+ 'description' => t('The number of links that the searchable item has linking to it')
---
+ 'description' => t('The number of links that the searchable item has linking to it.')

+ 'description' => t('The number of links that the searchable item has linking to it')
---
+ 'description' => t('The number of links that the searchable item has linking to it.')

+ // Update node_links_totals count for this node
---
+ // Update node_links_totals count for this node.

There is no attached patch in #4

Hmmm. D.o eats another patch. It's on my office computer so I'll upload it tomorrow. Thanks for noticing!

I believe that I meant to upload this patch (or did, and it went somewhere mysterious).

Bumping to 8.x at this point.

Drupal 8 core search had a totally broken implemention of the node link checking stuff, and so when we converted search to a plugin system, we stopped supporting node link checking. This would need to be done in a contrib module now. Sorry...