node titles with javascript reserved characters break the link and invalidate page
bangpound - May 12, 2008 - 02:08
| Project: | Share |
| Version: | 5.x-2.0-alpha2 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
node titles are are inserted into the share link code without being filtered first. when a node title has quotation marks in it, this causes the link for that node to break and the page to be invalid XHTML.
| Attachment | Size |
|---|---|
| share-title-encode.patch | 780 bytes |
#1
Whoops. I missed another instance of the same mistake. This patch corrects both of them.
#2
Hi,
I got the following results in my terminal window while patching:
patching file share.moduleHunk #1 succeeded at 264 with fuzz 1 (offset 1 line).
Hunk #2 succeeded at 336 with fuzz 1 (offset 2 lines).
So not exactly sure what that means, but it seemed to do the trick! Thanks :)
#3