hook_actions_info returning inappropriate array.

dopry - May 12, 2008 - 17:00
Project:Backup and Migrate
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

When you install backup_migrate for the first time you get a collection of errors regarding uninitialized indexes in actions.

Later if you just submit the admin/build/modules page you get and error about uninitialized array index 'configurable'.

A quick peek at hook_actions_info reveals the array it returns is improperly formatted. The attached patch updates the hook_actions_info to be compatible with D6. The action callbacks themselves may need to be modified.

AttachmentSize
backup_migrate-actions.patch797 bytes

#1

ronan - May 12, 2008 - 17:03

Awesome, thanks for the patch. Unfortunately I haven't had a lot of time to spend with the 6x version of the module but I'll try and get this tested and commited tonight or tomorrow,

thanks again

#2

dgorton - May 15, 2008 - 04:37

Ok - just so you know - Ronan is having a baby tomorrow (5/15 - C-Section - so it's scheduled). He isn't going to be around to answer questions for a while - and work has been busy on top of everything.

So - lest you despair over this patch, be aware that he's got some big things happening in life right now...

#3

dopry - May 15, 2008 - 04:51

congrats ronan!! I won't sweat not having this patch in... You should probably find someone to help with maintenance.... sorry to say it, but I think babies are more fun than drupal. :)

#4

dgorton - May 15, 2008 - 05:20

Ha! Yes, good points all around! Drupal is awesome, but there's something extra special 'bout them babies.
:)

I'm going to do what I can in the meantime - but that's pretty horribly limited... (sigh)
Drew

#5

ronan - July 13, 2008 - 21:01
Status:patch (code needs review)» fixed

Sorry about the extremely long delay. I have applied your patch and made some other minor modification and the action seems to work now.

Thanks for the patch

#6

Anonymous (not verified) - July 31, 2008 - 04:46
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.