mail2web blocks other modules from using mailhandler
| Project: | Mail to Web |
| Version: | 5.x-1.0-beta1 |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Ian Ward |
| Status: | active |
Jump to:
hey Jose, with the notifications_mail2web module, what do you think about a patch to return the node object in the mailhandler hook, even when the email is not found to be a response to a comment? This would allow using another mailhandler plugin module to handle the cases where you want to support actually starting a thread (posting a node, as opposed to a reply in a thread). What do you think about modules implementing the mailhandler hook in general? Should they all return the node in the event they're not able to act on the node object itself, in order for other plugin modules to have a shot at it?
If you agree w/ the patch to return the node when mail2web cannot act on the email, then I can roll one. This would obviously mean the extra security checks would not apply to the case of node creation, and instead only to replying to threads (which is thus handled by mail2web).
#1
I think it's ok as long as there's a setting for it (I.e. 'Allow only response mails', Y/N)
Otherwise our enhanced authentication system will be useless as emails with a valid from address will get in anyway.
#2
I think it may be also ok to have mail2web for only one of the mailboxes, other modules for the rest.
#3
I thought about doing an additional check like if ($header->toaddress == variable_get('mail2web_mailbox', '')) but this would make it not possible to have the mailbox be a catchall mailbox ;) You can do some nifty things if you use mail2web with a catchall mailbox. Making the setting like you're talking about - "Allow only response mails" seems ideal.
#4
Moving to new project
#5
Changing to better title.