hey Jose, with the notifications_mail2web module, what do you think about a patch to return the node object in the mailhandler hook, even when the email is not found to be a response to a comment? This would allow using another mailhandler plugin module to handle the cases where you want to support actually starting a thread (posting a node, as opposed to a reply in a thread). What do you think about modules implementing the mailhandler hook in general? Should they all return the node in the event they're not able to act on the node object itself, in order for other plugin modules to have a shot at it?

If you agree w/ the patch to return the node when mail2web cannot act on the email, then I can roll one. This would obviously mean the extra security checks would not apply to the case of node creation, and instead only to replying to threads (which is thus handled by mail2web).

Comments

jose reyero’s picture

jose reyero commented

I think it's ok as long as there's a setting for it (I.e. 'Allow only response mails', Y/N)

Otherwise our enhanced authentication system will be useless as emails with a valid from address will get in anyway.

jose reyero’s picture

jose reyero commented

I think it may be also ok to have mail2web for only one of the mailboxes, other modules for the rest.

Ian Ward’s picture

Ian Ward commented

I thought about doing an additional check like if ($header->toaddress == variable_get('mail2web_mailbox', '')) but this would make it not possible to have the mailbox be a catchall mailbox ;) You can do some nifty things if you use mail2web with a catchall mailbox. Making the setting like you're talking about - "Allow only response mails" seems ideal.

jose reyero’s picture

jose reyero commented
Project: Notifications » Mail to Web
Version: 5.x-1.x-dev » 5.x-1.0-beta1

Moving to new project

Ian Ward’s picture

Ian Ward commented
Title: Return node back to mailhandler to allow for other modules to act » mail2web blocks other modules from using mailhandler

Changing to better title.

davidteall’s picture

davidteall commented

Any progress to report?

Ian Ward’s picture

Ian Ward commented

Hi Med Man,

You can test the dev version for 5 which is available on the download page now. There is a readme about the additional configuration needed to set up the module and the input formats. If you're able to test it out, let me know how it goes.

thanks
Ian

davidteall’s picture

davidteall commented

I've just discovered your post. I have downloaded the dev version and will report back asap.

Thanks.

davidteall’s picture

davidteall commented

I have now given the dev version a very brief test. I shall do more tomorrow.

My main concern was to free up Mailhandler so that I could use a separate email address to post a NEW Topic to a Forum. This I can now do, but with a fatal problem. The Topic is posted as locked. That means that it is impossible to reply to it on line which defeats the purpose. The New Topic is distributed by m2w, I can reply to that by email, the incoming comment is uploaded at the next cron and is recorded as being there - but it is not visible!

This could be a Mailhandler setting problem rather than m2w I suppose. I have set the following default commands:

type: forum
taxonomy: [Cruising Conversations]
promote: 0
status: 1

Any ideas? Is there a command to lock/unlock a Forum post?

davidteall’s picture

davidteall commented

I've solved it! It was a Mailhandler problem. I added

comment: 2

to the list of commands and all now works correctly.

Thank you *very* much for this - it is very exciting. I now have the prospect of using Drupal's own Forums on my sites instead of a linked version of phpBB.

davidteall’s picture

davidteall commented

I have spent the morning giving the dev version a thorough test. I cannot fault it but I do have a couple of comments and questions:

I found the Installation Instruction#3 confusing. It says " ... on the input format for which you use on comments on your site." Is there such a global setting? If so, where is it? Is it not important here to set the Quoted Text Filter on the input format set in Mailhandler?

What criteria does the Quoted Text Filter use? I tried replying to a message by splitting up the quoted text and replying to it para by para as folk often do. I expected the quoted text to disappear but it didn't. Very clever - you were ahead of that problem. So what does get filtered out? Has it anything to do with the (((Reply ABOVE this LINE to POST a COMMENT))) line?

I am not sure what the Outbound filter does. If incoming messages have already been cleaned, why do you need an outbound filter?

Ian Ward’s picture

Ian Ward commented
Status: Active » Fixed

The fix for this is committed. Will be available in next release for both 5 and 6 at the end of this week.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Ian Ward’s picture

Ian Ward commented
Project: Mail to Web » Mail Comment
Version: 5.x-1.0-beta1 » 5.x-1.0-beta3

Switch to mailcomment project. Mail2web is now known as "mailcomment" due to a trademark issue with the name mail2web.