I've just tried to install Edit term on a 5.7 Drupal install and am seeing the following warning at the top of every page now:

Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /var/www/vhosts/digital-loom.com/subdomains/masstaxpayers/httpdocs/sites/default/modules/edit_term/edit_term.module on line 212

Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /var/www/vhosts/digital-loom.com/subdomains/masstaxpayers/httpdocs/sites/default/modules/edit_term/edit_term.module on line 216

Adding "ini_set('allow_call_time_pass_reference', 1);" to my settings.php file produces no change. Not sure if it's a PHP 4 v. 5 problem or what.

Comments

mlncn’s picture

mlncn commented

Thanks for the report, there's def. something wrong with the module then but it also seems your error reporting is putting warnings on the screen when it really shouldn't be that hypervigilant.

Do you know what version of PHP you're using?

Thanks,

benjamin, Agaric Design Collective

Digital Loom’s picture

Digital Loom commented

We're running PHP 4.3.9-3.22.9.

Right now the site's in development, so writing errors to the screen is more helpful than not.

mlncn’s picture

mlncn commented

Thanks, I'll try to look into this.

Meantime, the original module I coded is a bit different -- it puts edit links in a block rather than tabs, but it's simpler and I don't think will have the problem you're experiencing:

http://ftp.drupal.org/files/projects/edit_term-5.x-0.5-beta.tar.gz

benjamin, Agaric Design Collective

Digital Loom’s picture

Digital Loom commented

Thanks! I'll give it a shot.

Digital Loom’s picture

Digital Loom commented

Unfortunately, what I needed from Edit Term is the menu item creation, so the original module isn't helping.
UPDATE -- Realized I could install "Taxonomy Term Menu" and get the functionality I need.

dman’s picture

dman commented
Status: Active » Fixed

OK, that was a minor copy/paste inside edit_term_form_alter()
Not php-5-strict warnings compliant.

I've checked in the following fix. Thanks for the report!
I like easy problems.

--- edit_term.module    9 Apr 2008 03:41:25 -0000       1.1.2.2
+++ edit_term.module    24 Jun 2008 00:31:26 -0000
@@ -209,11 +209,11 @@
     $form['delete']['#weight'] = 11;

     // Add the menu editor
-    edit_term_menu_form($term, &$form);
+    edit_term_menu_form($term, $form);

     // Add the alias editor
     if (module_exists('path')) {
-      edit_term_path_form($term, &$form);
+      edit_term_path_form($term, $form);
     }
   }
 }
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.