Homepage links by unverified users do not properly have rel="nofollow" set
| Project: | Drupal |
| Version: | 6.2 |
| Component: | base system |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | duplicate |
Jump to:
After blogging about the fact I was getting more than the regular comment-spams (which Dries verified in Mollom) I found out people were trying to abuse comments on my site because of the high PageRank. Even though the site is moderated and none of those comments saw daylight, I was fed up by the amount of moderation work.
http://dag.wieers.com/blog/spam-comment-tale-continues
Today I looked through the code to follow up on some commenters' advice to add rel="nofollow" attributes to my contributed links and I noticed that in include/theme.inc on line 1576 the following:
$output = l($object->name, $object->homepage, array('rel' => 'nofollow'));should do what I want, only to discover that the line (according to function l()) should look like:
$output = l($object->name, $object->homepage, array('attributes' => array('rel' => 'nofollow')));I reported it to Dries, he asked me to create this bugreport and forwarded it to Gábor Hojtsy.
#1
Fix committed in http://drupal.org/cvs?commit=116255 thanks for the report!
#2
Duplicate of #227830: link attributes added to l() incorrectly
#3
So that I don’t make the same mistake I did when I marked #229817: Wrong use of l function in theme_username a dupe, let me clarify…
Gábor, please review #227830: link attributes added to l() incorrectly; it would have fixed both this issue and #229817.