Seems like it is impossible to hand over a custom submit handler to panels_edit_display()...
This would mean that the code

  if ($submit) {
    // The caller wants their own submit.
    $form['#submit'] = array($submit => array());
  }

in display_edit.inc (line 160ff.) was nonsense, or do I miss something?
Also it looks pretty awkward - doesn't it need to be: $form['#submit'] = array($submit)?

If I'm right, we can either remove those lines or add an optional $submit = NULL argument to the definition. I'd vote for the former then, to keep it simple. We might want to introduce that in a later API version.

Comments

sdboyer’s picture

Status: Active » Fixed

It is a relic, I'm pulling it out, thanks. However, if you check out the doxy docs on panels_edit_display(), then it should be clear how a submit why allowing for the addition of a submit handler in this way is superfluous - it's quite possible to simply pass the $display object back to the caller.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.