Closed (fixed)
Project:
Panels
Version:
5.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
14 May 2008 at 14:30 UTC
Updated:
28 May 2008 at 22:13 UTC
Seems like it is impossible to hand over a custom submit handler to panels_edit_display()...
This would mean that the code
if ($submit) {
// The caller wants their own submit.
$form['#submit'] = array($submit => array());
}
in display_edit.inc (line 160ff.) was nonsense, or do I miss something?
Also it looks pretty awkward - doesn't it need to be: $form['#submit'] = array($submit)?
If I'm right, we can either remove those lines or add an optional $submit = NULL argument to the definition. I'd vote for the former then, to keep it simple. We might want to introduce that in a later API version.
Comments
Comment #1
sdboyer commentedIt is a relic, I'm pulling it out, thanks. However, if you check out the doxy docs on panels_edit_display(), then it should be clear how a submit why allowing for the addition of a submit handler in this way is superfluous - it's quite possible to simply pass the $display object back to the caller.
Comment #2
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.