This patch splits parser code (~600 lines) into a common_syndication.inc file. common_syndication.inc is only loaded while refreshing a feed.

CommentFileSizeAuthor
#4 258434-4_common_syndication_inc.patch58.26 KBaron novak
#2 common_syndication_inc_2.patch43.44 KBmustafau
common_syndication_inc.patch42.92 KBmustafau

Comments

mustafau’s picture

mustafau commented
Priority: Normal » Critical
mustafau’s picture

mustafau commented
StatusFileSize
new common_syndication_inc_2.patch43.44 KB

Re-roll.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Component: Code » Code feedapi (core module)
Status: Needs review » Needs work

This is such a patch what I would like to see in FeedAPI 1.9.
Needs work, because it's rather old :)

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs work » Needs review
StatusFileSize
new 258434-4_common_syndication_inc.patch58.26 KB

Rerolled to reflect the latest changes of the module.

alex_b’s picture

alex_b commented

Looks good. If this passes the tests I'm all for RTBC.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs review » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.