In panels_edit_cache_settings_form_validate, we don't need a $method variable if it is called only once.

CommentFileSizeAuthor
#1 panels_edit_cache_settings_form_submit.patch1.6 KBpancho
panels_edit_cache_settings_form_validate.patch830 bytespancho

Comments

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Title: panels_edit_cache_settings_form_validate » Broken: panels_edit_cache_settings_form_submit()
Priority: Minor » Normal
StatusFileSize
new panels_edit_cache_settings_form_submit.patch1.6 KB

Also, panels_edit_cache_settings_form_submit() is broken and won't call the client's submit handler.
Rolled the original, minor issue in.

sdboyer’s picture

sdboyer commented
Status: Needs review » Fixed

Hah, this is one of those ones where I look at it and ask myself, REALLY? That REALLY made it through?

/me needs to simpletest panels or something. oi.

Committed - thanks again, as usual, Pancho!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.