Fix imagefield 1.x -> 2.x upgrade path. Rename default formatters from $name to $name .'_default'.

You will need to go and update/reset all the formatters on admin/content/types/$type/display. It seems I missed this part of the upgrade path. I'll try to figure out a way to correct when I'm working on imagefield next this weds, but it is easily curable by updating the display settings page, if tedious.

The new formatter handling code changed the name of the default formatter to from $preset['name'] to $preset['name'] .'_default'. This applies to both imagefield and imagecache. The update function should iterate over all function types, updating the formatter name if it hasn't been updated already.

> However, the ajax upload seems to be broken now! But only for imagefield uploads. It keeps on displaying the loading bar.

I bet three euros that you've got the Devel module enabled, which causes AJAX uploads (not only those in imagefield, but also in upload.module and filefield) to stall.

Sorry.. this is still active as there is an involved upgrade path that needs to be fixed as well...

No images are displayed in 'view' mode. Devel is not enabled.

I bet three euros that you've got the Devel module enabled, which causes AJAX uploads (not only those in imagefield, but also in upload.module and filefield) to stall.

Thank you! I was about to do drastic things. I guess I missed that in some Devel documentation...

Implemented the update path as outlined in #2. However, I think the name of the default formatter changed from just 'default' to 'imagefield_default', don't know where $preset['name'] fits in there.

Added clearing of content type cache after update.

i think imagefield still has a bug trying to load default image.. all i see on node_load() for a field with no image but with a defauklt.. is that the field is not populated into the node object.

also, patch in #11 fails on call to undefined function _content_admin_display_contexts()

how is it this hasn't been sorted out.. doesnt everyone use this module???

Duplicate? This patch worked for me: http://drupal.org/node/318058

I committed the attached to HEAD so that it'd stay consistent.

committed smk-ka's patch to DRUPAL-5--2.

The same problem applies to default Views (5.x) formatters, this patch fixed every view I had that used imagefield.

nice, wrong way patch... sorry

i think we could do without the first place holder ala:

+    if (module_exists('views')) {
+      db_query("UPDATE {view_tablefield} SET options = 'imagefield_default' WHERE field = '%s_fid' AND options = 'default'", $row['field_name']);
+    }

also how about making it into a separate update?

without first placeholder and as a separate update

note: The same thing would need to be done for every imagecache presets' defaults (ie. "YourImagecachePreset" for "YourImagecachePreset_default"), or you have to manually edit your view and re-set it.

caktux, this change is no longer necessary after #402200: Restore the "default" Formatter. This whole changing the name of the default formatter was a bad idea from the start.