I have a strange behaviour in my site guestbook: I can post as anonymous user and I'm able to see, that the post went to the guestbook emediately, so ther seems to be no caching problem. I disabled caching for testing, but nothing changed.

The problem is, that all posts have text "n/a". You can have a look at it: http://beta.des-kehrt-so.de/?q=guestbook

When accessing the guestbook as admin, the entries are all there and the text is as entered.

CommentFileSizeAuthor
#4 guestbook.module.patch654 bytesAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
Version: 6.x-1.0-rc1 » 6.x-1.x-dev

The Problem exists in the current devel version, too.

I fixed it, it is a displaced parenthesis in line 728 of guestbook.module (devel version). The correct line is:

$output .= '<div class="content guestbook-message">'. check_markup($entry['message'], variable_get('guestbook_input_format', 1), FALSE) .'</div>';

Please someone create a .patch for that, as I am a dump windows user, not interested in installing halfheartedly portet linux tools on my machine.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs work
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Priority: Critical » Normal

Cygwin tools, containing a Win32 port of diff and patch, are everything except halfheartedly ported linux tools. Go grab yourself a copy, add TortoiseCVS, read http://drupal.org/patch/create, and start to contribute!

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
StatusFileSize
new guestbook.module.patch654 bytes

As I found out, how to generate patches in the right format with WinMerge, I attached my .patch to this post.

The cygwin middleware is not what I expect. unix tools are the way, I'd like to use ported software, but the current release seems to be buggy.

I asked for a CVS account two times, but I didn't get one, yet.

I'd enjoy contributing in an easyer way, but without a CVS account, there is no chance. With this account, it is possible for me, to condibute, but in my oppinion, CVS is, like cygwin, software from the last century. Even with TortoiseCVS, it's much more difficult to use, than SVN.

Hope, the patch helps.
forschi

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Thanks, committed to all branches.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.