Comments

webchick’s picture

Status: Active » Needs review
StatusFileSize
new1.54 KB

Patch.

webchick’s picture

Status: Needs review » Fixed
StatusFileSize
new1.51 KB

k, committed this to HEAD and DRUPAL-6--1. I'm sure this still needs copious amounts of work, but at least there's something there now.

merlinofchaos’s picture

This is a good start. This documentation should probably attempt to describe some of what will be found in the registry, though that's going to take some effort. Though hook_theme covers most of it, there's a few things in there that aren't necessarily in hook_theme.

webchick’s picture

Status: Fixed » Needs review
StatusFileSize
new5.41 KB

Ok, after discussing w/ merlinofchaos on IRC, I made the following changes:

1. Added 'type', 'theme path', and 'theme paths' to hook_theme() docs, so there's only one place to refer to (and update as it changes) for a list of all these properties.
2. Moved 'arguments' to the top, while I was at it, since it's the only required value.
3. Added a code sample of what a given array index looks like in hook_theme_registry_alter().

Patch attached.

webchick’s picture

Typo.

webchick’s picture

And, oops. I didn't mean to move the position of 'file'.

webchick’s picture

Also, I didn't mean to remove the bit about cache clearage.

Have I mentioned I should've gone to bed about an hour ago? :P

webchick’s picture

Status: Needs review » Fixed

Well I accidentally committed this when I fixed #217912: Document undocumented hooks (currently 1 remaining on list). Since there's been no comment on this issue for a few days, I'm assuming there wasn't anything too horrible in there. Marking fixed again.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.